You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/05/18 22:58:27 UTC
[GitHub] [helix] pkuwm opened a new issue #1017: Wait until connected for new ZkConnection created for ZkConnectionManager in SharedZkClient
pkuwm opened a new issue #1017:
URL: https://github.com/apache/helix/issues/1017
`SharedZkClientFactory` creates ZkConnectionManager before the zkSession in the new ZkConnection is established. And it causes this ZkConnectionManager not able to be constructed, because the raw zkClient checks the connection. If the new zkclient does not manage connection but the connection is not established, the zkclient will be closed and cause exceptions.
```
private ZkConnectionManager getOrCreateZkConnectionManager(
HelixZkClient.ZkConnectionConfig connectionConfig, long connectInitTimeout) {
ZkConnectionManager connectionManager = _connectionManagerPool.get(connectionConfig);
if (connectionManager == null || connectionManager.isClosed()) {
connectionManager =
new ZkConnectionManager(createZkConnection(connectionConfig), connectInitTimeout,
connectionConfig.toString());
_connectionManagerPool.put(connectionConfig, connectionManager);
}
return connectionManager;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm closed issue #1017: Wait until connected for new ZkConnection created for ZkConnectionManager in SharedZkClient
Posted by GitBox <gi...@apache.org>.
pkuwm closed issue #1017:
URL: https://github.com/apache/helix/issues/1017
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org