You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/20 16:14:00 UTC

[jira] [Commented] (FLINK-9033) Replace usages of deprecated TASK_MANAGER_NUM_TASK_SLOTS

    [ https://issues.apache.org/jira/browse/FLINK-9033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406577#comment-16406577 ] 

ASF GitHub Bot commented on FLINK-9033:
---------------------------------------

GitHub user yew1eb opened a pull request:

    https://github.com/apache/flink/pull/5731

    [FLINK-9033][config] Replace usages of deprecated TASK_MANAGER_NUM_TASK_SLOTS

    ## What is the purpose of the change
    
    The deprecated ConfigConstants#TASK_MANAGER_NUM_TASK_SLOTS is still used a lot.
    We should replace these usages with TaskManagerOptions#NUM_TASK_SLOTS.
    
    ## Verifying this change
    
    - `mvn clean verify`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yew1eb/flink FLINK-9033

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5731.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5731
    
----

----


> Replace usages of deprecated TASK_MANAGER_NUM_TASK_SLOTS
> --------------------------------------------------------
>
>                 Key: FLINK-9033
>                 URL: https://issues.apache.org/jira/browse/FLINK-9033
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: 1.5.0
>            Reporter: Hai Zhou
>            Assignee: Hai Zhou
>            Priority: Major
>             Fix For: 1.5.0
>
>
> The deprecated ConfigConstants#TASK_MANAGER_NUM_TASK_SLOTS is still used a lot.
> We should replace these usages with TaskManagerOptions#NUM_TASK_SLOTS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)