You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by GitBox <gi...@apache.org> on 2021/03/10 05:35:05 UTC
[GitHub] [atlas] AmeerAssi opened a new pull request #127: Update objectPrefix isUnique for aws_s3_v2_directory to false
AmeerAssi opened a new pull request #127:
URL: https://github.com/apache/atlas/pull/127
objectPrefix attribute in aws_s3_v2_directory is a required field, in addition its isUnique property is true.
based on the test here: (see verifyS3V2PseudoDir)
https://github.com/apache/atlas/blob/d27790dfdde09a58db15064bbdaf77d224f61ecc/common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java
if we have 2 AWS S3 files from different buckets:
1. s3://aws_my_bucket1/1234567890/test.csv
2. s3://aws_my_bucket2/1234567890/test.csv
as you see there is 2 different directories from different buckets, but having same objectPrefix, and different qualified name.
object 1:
aws_s3_v2_directory: qualifiedName: "s3://aws_my_bucket1/1234567890/"
objectPrefix: "/1234567890/"
object 2:
aws_s3_v2_directory:
qualifiedName: "s3://aws_my_bucket2/1234567890/"
objectPrefix: "/1234567890/"
which making the objectPrefix isUnique property conflicting with qualified name property.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [atlas] AmeerAssi closed pull request #127: Update objectPrefix isUnique for aws_s3_v2_directory to false
Posted by GitBox <gi...@apache.org>.
AmeerAssi closed pull request #127:
URL: https://github.com/apache/atlas/pull/127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [atlas] sidharthkmishra commented on pull request #127: Update objectPrefix isUnique for aws_s3_v2_directory to false
Posted by GitBox <gi...@apache.org>.
sidharthkmishra commented on pull request #127:
URL: https://github.com/apache/atlas/pull/127#issuecomment-809752608
This change has been merged already. @AmeerAssi Please close the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [atlas] sidharthkmishra commented on a change in pull request #127: Update objectPrefix isUnique for aws_s3_v2_directory to false
Posted by GitBox <gi...@apache.org>.
sidharthkmishra commented on a change in pull request #127:
URL: https://github.com/apache/atlas/pull/127#discussion_r591753655
##########
File path: addons/models/3000-Cloud/patches/007-s3_v2_update_attributes.json
##########
@@ -0,0 +1,23 @@
+{
+ "patches": [
+ {
+ "id": "TYPEDEF_PATCH_3000_007_001",
+ "description": "Update objectPrefix isUnique for aws_s3_v2_directory to false",
+ "action": "UPDATE_ATTRIBUTE",
+ "typeName": "aws_s3_v2_directory",
+ "applyToVersion": "1.1",
+ "updateToVersion": "1.2",
Review comment:
Please change the aws_s3_v2_directory's objectPrefix attribute at 3030-aws_s3_v2_typedefs.json file too and change the typeVersion. The patch file will ensure the model upgrade for older version and the new installation will be created with newer version from 3030-aws_s3_v2_typedefs.json
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org