You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/19 14:08:20 UTC
[GitHub] [pulsar] lhotari opened a new pull request, #15221: Skip unnecessary DNS resolution when creating AuthenticationDataHttp instance
lhotari opened a new pull request, #15221:
URL: https://github.com/apache/pulsar/pull/15221
### Motivation
Using the DNS resolution is a blocking operation in Java. In this case it's completely unnecessary to do a reverse lookup for the client's IP address.
### Modifications
- Use Netty's utility class to create a InetAddress instance from the IP address string without using DNS resolution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #15221: Skip unnecessary DNS resolution when creating AuthenticationDataHttp instance
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #15221:
URL: https://github.com/apache/pulsar/pull/15221#issuecomment-1103476258
I created a follow up PR #15228 since in this case, the use of `InetSocketAddress.createUnresolved` method would be the correct solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #15221: Skip unnecessary DNS resolution when creating AuthenticationDataHttp instance
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #15221:
URL: https://github.com/apache/pulsar/pull/15221#issuecomment-1112114175
@lhotari This and the follow up commits are labelled with 2.10 but I don't see the related changes on branch-2.10 https://github.com/apache/pulsar/blob/branch-2.10/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationDataHttp.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #15221: Skip unnecessary DNS resolution when creating AuthenticationDataHttp instance
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #15221:
URL: https://github.com/apache/pulsar/pull/15221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org