You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by abdelhakim deneche <ad...@gmail.com> on 2015/03/06 02:26:17 UTC

Review Request 31783: DRILL-2220: Complex reader unable to read FIXED_LEN_BYTE_ARRAY types in parquet file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31783/
-----------------------------------------------------------

Review request for drill and Steven Phillips.


Bugs: DRILL-2220
    https://issues.apache.org/jira/browse/DRILL-2220


Repository: drill-git


Description
-------

this patch fixes the _DrillParquetReader_ to properly handle _FIXED_LEN_BYTE_ARRAY_ type, and also to take into account the scale and precision of the field


Diffs
-----

  exec/java-exec/src/main/codegen/templates/AbstractFieldWriter.java 145130b 
  exec/java-exec/src/main/codegen/templates/BaseWriter.java 979d4ac 
  exec/java-exec/src/main/codegen/templates/MapWriters.java b8d5365 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetGroupConverter.java d219927 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet2/TestDrillParquetReader.java PRE-CREATION 
  exec/java-exec/src/test/resources/parquet2/decimal28_38.parquet PRE-CREATION 

Diff: https://reviews.apache.org/r/31783/diff/


Testing
-------

added new unit test to make sure DECIMAL28/DECIMAL38 fields are read correctly when they are OPTIONAL or REQUIRED
all unit tests are passing along with functional, customer and tpch100


Thanks,

abdelhakim deneche