You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/01 15:38:27 UTC

[GitHub] [incubator-druid] gianm commented on issue #7386: Why mark `maxPendingPersists` as deprecated

gianm commented on issue #7386: Why mark `maxPendingPersists` as deprecated
URL: https://github.com/apache/incubator-druid/issues/7386#issuecomment-478631018
 
 
   I'm not sure if there was a correctness reason for doing this or not so I can't speak to that.
   
   Its behavior can definitely be unintuitive with regard to memory use though: each pending persist adds another potentially-full IncrementalIndex and so increases memory requirements beyond what you might expect based on a particular maxRowsInMemory setting. But I'm not sure if that's why it was marked deprecated or not. I don't see much discussion about it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org