You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/09/26 10:57:11 UTC
[GitHub] [calcite] wojustme opened a new pull request, #2920: [CALCITE-5296] Infer rowtype error, when meeting function with group-set's item in the SELECT statement
wojustme opened a new pull request, #2920:
URL: https://github.com/apache/calcite/pull/2920
ISSUE: https://issues.apache.org/jira/browse/CALCITE-5296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] libenchao closed pull request #2920: [CALCITE-5296] In a query with ROLLUP, validator wrongly infers that a column is NOT NULL
Posted by GitBox <gi...@apache.org>.
libenchao closed pull request #2920: [CALCITE-5296] In a query with ROLLUP, validator wrongly infers that a column is NOT NULL
URL: https://github.com/apache/calcite/pull/2920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] wojustme commented on a diff in pull request #2920: [CALCITE-5296] In a query with ROLLUP, validator wrongly infers that a column is NOT NULL
Posted by GitBox <gi...@apache.org>.
wojustme commented on code in PR #2920:
URL: https://github.com/apache/calcite/pull/2920#discussion_r990634393
##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -4688,4 +4688,5 @@ void checkCorrelatedMapSubQuery(boolean expand) {
String sql = "SELECT CAST(CAST(? AS INTEGER) AS CHAR)";
sql(sql).ok();
}
+
Review Comment:
Thank you for reminding me.
And PR is updated, please review again.
Ping me to rebase it, if it's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] libenchao commented on a diff in pull request #2920: [CALCITE-5296] In a query with ROLLUP, validator wrongly infers that a column is NOT NULL
Posted by GitBox <gi...@apache.org>.
libenchao commented on code in PR #2920:
URL: https://github.com/apache/calcite/pull/2920#discussion_r990601217
##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -4688,4 +4688,5 @@ void checkCorrelatedMapSubQuery(boolean expand) {
String sql = "SELECT CAST(CAST(? AS INTEGER) AS CHAR)";
sql(sql).ok();
}
+
Review Comment:
nit: unrelated change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] wojustme commented on a diff in pull request #2920: [CALCITE-5296] In a query with ROLLUP, validator wrongly infers that a column is NOT NULL
Posted by GitBox <gi...@apache.org>.
wojustme commented on code in PR #2920:
URL: https://github.com/apache/calcite/pull/2920#discussion_r990634393
##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -4688,4 +4688,5 @@ void checkCorrelatedMapSubQuery(boolean expand) {
String sql = "SELECT CAST(CAST(? AS INTEGER) AS CHAR)";
sql(sql).ok();
}
+
Review Comment:
@libenchao
Thank you for reminding me.
And PR is updated, please review again.
Ping me to rebase it, if it's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org