[GitHub] [flink] Myasuka commented on a diff in pull request #19600: [FLINK-27433][tests] Move RocksDB's log location to /tmp for e2e tests

[GitBox <gi...@apache.org>]

Myasuka commented on code in PR #19600:
URL: https://github.com/apache/flink/pull/19600#discussion_r865511866


##########
flink-end-to-end-tests/test-scripts/common.sh:
##########
@@ -305,6 +305,10 @@ function wait_dispatcher_running {
 }
 
 function start_cluster {
+  # After FLINK-24785, RocksDB's log would be created under Flink's log directory by default,
+  # this would make e2e tests' artifacts containing too many log files.
+  # As RocksDB's log would not help much in e2e tests, move the location to the '/tmp' folder.
+  set_config_key "state.backend.rocksdb.log.dir" "/tmp"

Review Comment:
   If relocating to RocksDB's own folder, the folder itself will be cleaned up when the RocksDB state-backend disposed just as before. In other words, we don't need to manually clean up the log files but the parent folder will be cleaned up automatically.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org