You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "ibrijesh (via GitHub)" <gi...@apache.org> on 2023/03/13 14:38:58 UTC
[GitHub] [incubator-eventmesh] ibrijesh opened a new pull request, #3444: ISSUE #3412: Make Logger a static final constant
ibrijesh opened a new pull request, #3444:
URL: https://github.com/apache/incubator-eventmesh/pull/3444
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3412
*Describe the modifications you've done.*
Maked Logger a static final constant.
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3444: ISSUE #3412: Make Logger a static final constant
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3444:
URL: https://github.com/apache/incubator-eventmesh/pull/3444#issuecomment-1466354828
## [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3444?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3444](https://codecov.io/gh/apache/incubator-eventmesh/pull/3444?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1afd04) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/b6d85a44baddb2dfbf2d84369143b95b5a51f4f5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6d85a4) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head d1afd04 differs from pull request most recent head 8e6ca74. Consider uploading reports for the commit 8e6ca74 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3444 +/- ##
============================================
+ Coverage 13.92% 13.95% +0.02%
- Complexity 1438 1442 +4
============================================
Files 636 636
Lines 31375 31375
Branches 3008 3008
============================================
+ Hits 4368 4377 +9
+ Misses 26630 26620 -10
- Partials 377 378 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ttp/processor/RemoteUnSubscribeEventProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvUmVtb3RlVW5TdWJzY3JpYmVFdmVudFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
... and [2 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-eventmesh/pull/3444/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mytang0 merged pull request #3444: ISSUE #3412: Make Logger a static final constant
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 merged PR #3444:
URL: https://github.com/apache/incubator-eventmesh/pull/3444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org