You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/28 19:45:41 UTC

[GitHub] [flink-kubernetes-operator] tedhtchang opened a new pull request, #188: [FLINK-27129][docs] Hardcoded namespace in FlinkDeployment manifests may fail to deploy

tedhtchang opened a new pull request, #188:
URL: https://github.com/apache/flink-kubernetes-operator/pull/188

   Remove hardcode default namespace from the flinkdeployment examples.
   Document the step to create flinkdeployment in other namespaces when watchNamespaces not used.
   
   Signed-off-by: ted chang <ht...@us.ibm.com>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] tedhtchang commented on pull request #188: [FLINK-27129][docs] Hardcoded namespace in FlinkDeployment manifests may fail to deploy

Posted by GitBox <gi...@apache.org>.
tedhtchang commented on PR #188:
URL: https://github.com/apache/flink-kubernetes-operator/pull/188#issuecomment-1113758507

   @morhidi Thanks for reviewing. I updated document.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #188: [FLINK-27129][docs] Hardcoded namespace in FlinkDeployment manifests may fail to deploy

Posted by GitBox <gi...@apache.org>.
mbalassi merged PR #188:
URL: https://github.com/apache/flink-kubernetes-operator/pull/188


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #188: [FLINK-27129][docs] Hardcoded namespace in FlinkDeployment manifests may fail to deploy

Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #188:
URL: https://github.com/apache/flink-kubernetes-operator/pull/188#issuecomment-1113133688

   This PR looks good, nit: I would emphasise that the scripts/deployments will run in the default namespace, that must be change using `kubectl config set-context --current --namespace=CHANGEIT` cc @mbalassi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #188: [FLINK-27129][docs] Hardcoded namespace in FlinkDeployment manifests may fail to deploy

Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #188:
URL: https://github.com/apache/flink-kubernetes-operator/pull/188#issuecomment-1114705134

   Thanks @tedhtchang.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #188: [FLINK-27129][docs] Hardcoded namespace in FlinkDeployment manifests may fail to deploy

Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #188:
URL: https://github.com/apache/flink-kubernetes-operator/pull/188#issuecomment-1114641547

   Thanks @tedhtchang. @mbalassi PTAL and merge if there are no further comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org