[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2269: Handle symlinks in LocalFileSystem (#2206)

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2269:
URL: https://github.com/apache/arrow-rs/pull/2269#discussion_r934724179


##########
object_store/src/path/mod.rs:
##########
@@ -295,20 +294,13 @@ where
     }
 }
 
-/// Given a filesystem path, convert it to its canonical URL representation,
-/// returning an error if the file doesn't exist on the local filesystem
+/// Given a filesystem path convert it to a URL representation
 pub(crate) fn filesystem_path_to_url(
     path: impl AsRef<std::path::Path>,
 ) -> Result<Url, Error> {
-    let path = path.as_ref().canonicalize().context(CanonicalizeSnafu {

Review Comment:
   This is the change that makes this possible, we no longer canonicalize the paths



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org