You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/23 16:10:05 UTC
[GitHub] [flink] Zarathustra2 opened a new pull request #18451: [FLINK-24623] [EventTimeWindowing]: Prevent usage of EventTimeWindows when EventTime is disabled
Zarathustra2 opened a new pull request #18451:
URL: https://github.com/apache/flink/pull/18451
## What is the purpose of the change
Prevent usage of EventTimeWindows when EventTime is disabled. For instance:
```java
source.assignTimestampsAndWatermarks(WatermarkStrategy.noWatermarks())
.keyBy(t -> t.f1)
.window(SlidingEventTimeWindows.of(Time.milliseconds(1), Time.milliseconds(10)))
.process(...)
.print();
```
Would never window any inputs as the preceding watermark generator does not emit watermarks.
This PR introduces a runtime check which throws an exception on startup if any event time window has an invalid immediate preceding event time generator.
## Brief change log
- *Check for any event time window that it does not have an invalid (for instance, noWatermark()) preceding event time generator*
## Verifying this change
This change added tests and can be verified as follows:
- *Added integration tests that asserts that an exception is thrown if an event time window has an invalid preceding watermark generator*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18451: [FLINK-24623] [EventTimeWindowing]: Prevent usage of EventTimeWindows when EventTime is disabled
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18451:
URL: https://github.com/apache/flink/pull/18451#issuecomment-1019517165
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 276b3d2642da698b19a42843467ccd27b0c1d41a (Sun Jan 23 16:14:51 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24623).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18451: [FLINK-24623] [EventTimeWindowing]: Prevent usage of EventTimeWindows when EventTime is disabled
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18451:
URL: https://github.com/apache/flink/pull/18451#issuecomment-1019516830
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "276b3d2642da698b19a42843467ccd27b0c1d41a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "276b3d2642da698b19a42843467ccd27b0c1d41a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 276b3d2642da698b19a42843467ccd27b0c1d41a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18451: [FLINK-24623] [EventTimeWindowing]: Prevent usage of EventTimeWindows when EventTime is disabled
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18451:
URL: https://github.com/apache/flink/pull/18451#issuecomment-1019516830
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "276b3d2642da698b19a42843467ccd27b0c1d41a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29955",
"triggerID" : "276b3d2642da698b19a42843467ccd27b0c1d41a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 276b3d2642da698b19a42843467ccd27b0c1d41a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29955)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18451: [FLINK-24623] [EventTimeWindowing]: Prevent usage of EventTimeWindows when EventTime is disabled
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18451:
URL: https://github.com/apache/flink/pull/18451#issuecomment-1019516830
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "276b3d2642da698b19a42843467ccd27b0c1d41a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29955",
"triggerID" : "276b3d2642da698b19a42843467ccd27b0c1d41a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 276b3d2642da698b19a42843467ccd27b0c1d41a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29955)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org