You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@johnzon.apache.org by GitBox <gi...@apache.org> on 2022/10/13 15:27:09 UTC
[GitHub] [johnzon] SingingBush opened a new pull request, #94: GitHub actions
SingingBush opened a new pull request, #94:
URL: https://github.com/apache/johnzon/pull/94
similar to #75 but with a few differences and dependency tweaks. I've pulled out cobertura for now as it's dead. JaCoCo should be setup in it's place. I'm keen to open a few more PR's but having a visible CI is essential so really need to get github actions up and running to have any confidence in future PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rmannibucau merged pull request #94: GitHub actions
Posted by GitBox <gi...@apache.org>.
rmannibucau merged PR #94:
URL: https://github.com/apache/johnzon/pull/94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rmannibucau commented on a diff in pull request #94: GitHub actions
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on code in PR #94:
URL: https://github.com/apache/johnzon/pull/94#discussion_r994885019
##########
.github/dependabot.yml:
##########
@@ -0,0 +1,7 @@
+version: 2
Review Comment:
I'm really for not using depandabot which got proven to create more noise than solving any actual issue in practise on most asf project, is it ok to drop it?
##########
.github/workflows/maven.yml:
##########
@@ -0,0 +1,34 @@
+name: Maven
+
+on: [push, pull_request]
+
+jobs:
+ build:
+ name: Test with Java ${{ matrix.jdk }}
+ #runs-on: ${{ matrix.os }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ jdk: [ '11', '17', '19' ]
+ dist: [ 'zulu' ]
+ include:
+ - { jdk: '8', dist: 'adopt' } # Zulu doesn't have JDK 8
+
+ steps:
+ - uses: actions/checkout@v3
+ - name: Set up JDK ${{ matrix.jdk }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ matrix.jdk }}
+ distribution: ${{ matrix.dist }}
+ cache: 'maven'
+
+ - name: Maven Rat Check
+ run: mvn -V apache-rat:check --no-transfer-progress
+
+ - name: Maven Verify
+ run: mvn -V verify --no-transfer-progress
Review Comment:
maybe add `MAVEN_OPTS=-Dmaven.artifact.threads=64`
##########
.github/workflows/maven.yml:
##########
@@ -0,0 +1,34 @@
+name: Maven
+
+on: [push, pull_request]
+
+jobs:
+ build:
+ name: Test with Java ${{ matrix.jdk }}
+ #runs-on: ${{ matrix.os }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ jdk: [ '11', '17', '19' ]
+ dist: [ 'zulu' ]
+ include:
+ - { jdk: '8', dist: 'adopt' } # Zulu doesn't have JDK 8
Review Comment:
zulu stil has v8 -> https://cdn.azul.com/zulu/bin/
is it a big of the related action?
##########
.github/workflows/maven.yml:
##########
@@ -0,0 +1,34 @@
+name: Maven
+
+on: [push, pull_request]
+
+jobs:
+ build:
+ name: Test with Java ${{ matrix.jdk }}
+ #runs-on: ${{ matrix.os }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ jdk: [ '11', '17', '19' ]
+ dist: [ 'zulu' ]
+ include:
+ - { jdk: '8', dist: 'adopt' } # Zulu doesn't have JDK 8
+
+ steps:
+ - uses: actions/checkout@v3
+ - name: Set up JDK ${{ matrix.jdk }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ matrix.jdk }}
+ distribution: ${{ matrix.dist }}
+ cache: 'maven'
+
+ - name: Maven Rat Check
+ run: mvn -V apache-rat:check --no-transfer-progress
+
+ - name: Maven Verify
+ run: mvn -V verify --no-transfer-progress
Review Comment:
`mvn package` is sufficient, verify just slows down the build with no gain
##########
.github/workflows/maven.yml:
##########
@@ -0,0 +1,34 @@
+name: Maven
+
+on: [push, pull_request]
+
+jobs:
+ build:
+ name: Test with Java ${{ matrix.jdk }}
+ #runs-on: ${{ matrix.os }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ jdk: [ '11', '17', '19' ]
+ dist: [ 'zulu' ]
+ include:
+ - { jdk: '8', dist: 'adopt' } # Zulu doesn't have JDK 8
+
+ steps:
+ - uses: actions/checkout@v3
+ - name: Set up JDK ${{ matrix.jdk }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ matrix.jdk }}
+ distribution: ${{ matrix.dist }}
+ cache: 'maven'
+
+ - name: Maven Rat Check
+ run: mvn -V apache-rat:check --no-transfer-progress
Review Comment:
not needed thanks to next step
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org