You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openjpa.apache.org by mi...@apache.org on 2010/08/13 04:03:48 UTC

svn commit: r985067 - /openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java

Author: mikedd
Date: Fri Aug 13 02:03:48 2010
New Revision: 985067

URL: http://svn.apache.org/viewvc?rev=985067&view=rev
Log:
Increase timeout value for slice testcase

Modified:
    openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java

Modified: openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java?rev=985067&r1=985066&r2=985067&view=diff
==============================================================================
--- openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java (original)
+++ openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java Fri Aug 13 02:03:48 2010
@@ -49,6 +49,7 @@ public class TestQueryMultiThreaded exte
     private int VALUE_MIN = 100;
     private int VALUE_MAX = VALUE_MIN + POBJECT_COUNT - 1;
     private static int THREADS = 5;
+    private static int MAX_TIMEOUT = 300;
     private ExecutorService group; 
     private Future[] futures;
 
@@ -337,7 +338,7 @@ public class TestQueryMultiThreaded exte
         try {
             for (Future f : futures)
                 try {
-                    f.get(60, TimeUnit.SECONDS);
+                    f.get(MAX_TIMEOUT, TimeUnit.SECONDS);
                 } catch (TimeoutException te) {
                     fail("Failed " + te + "\r\n" + getStackDump(te));
                 } catch (ExecutionException e) {



Re: svn commit: r985067 - /openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java

Posted by Michael Dick <mi...@gmail.com>.
At first glance a single lock should work - removing the sm lock should
prevent deadlocks down the road.

I'm not sure if I can reproduce the problem on my laptop - might have to
wait until I get home to try it out.

Thanks for the pointer to OpenJPA-453 - lots of data there I'll have to read
up a bit.

-mike

On Mon, Aug 16, 2010 at 1:29 PM, Ravi Palacherla <ravi.palacherla@oracle.com
> wrote:

> This patch does broker lock and in that case, is there a need for sm lock
> too ?
> Can we eliminate the sm lock and rely completely on broker lock?
> The patch for the above is in 453.
>
> Regards,
> Ravi.
>
> -----Original Message-----
> From: Rick Curtis [mailto:curtisr7@gmail.com]
> Sent: Monday, August 16, 2010 12:25 PM
> To: dev@openjpa.apache.org
> Subject: Re: svn commit: r985067 -
> /openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
>
> Go ahead and pull the trigger.
>
> On Mon, Aug 16, 2010 at 1:20 PM, Michael Dick <michael.d.dick@gmail.com
> >wrote:
>
> > I understand your concern about giving people a false sense of confidence
> -
> > openjpa.Multithreaded requires more than just this fix. OTOH it's going
> to
> > be a while before we have the whole solution.
> >
> > If you don't have a specific concern with the patch I'll go ahead and
> > commit
> > it - I don't see it as dangerous for normal (non openpja.Multithreaded)
> use
> > and we have at least one testcase which depends on it.
> >
> > -mike
> >
> > On Mon, Aug 16, 2010 at 8:50 AM, Rick Curtis <cu...@gmail.com> wrote:
> >
> > >
> > > My biggest concern with that fix is that it isn't a complete fix for
> the
> > > openjpa.Multithreaded property. It fixes the one one reported bug, but
> > > there
> > > are numerous others out there.
> > >
> > > I'd really like to see someone find some time to come up with a
> complete
> > > multi threaded story for openjpa.
> >
> >
>

RE: svn commit: r985067 - /openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java

Posted by Ravi Palacherla <ra...@oracle.com>.
This patch does broker lock and in that case, is there a need for sm lock too ?
Can we eliminate the sm lock and rely completely on broker lock?
The patch for the above is in 453.

Regards,
Ravi.

-----Original Message-----
From: Rick Curtis [mailto:curtisr7@gmail.com] 
Sent: Monday, August 16, 2010 12:25 PM
To: dev@openjpa.apache.org
Subject: Re: svn commit: r985067 - /openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java

Go ahead and pull the trigger.

On Mon, Aug 16, 2010 at 1:20 PM, Michael Dick <mi...@gmail.com>wrote:

> I understand your concern about giving people a false sense of confidence -
> openjpa.Multithreaded requires more than just this fix. OTOH it's going to
> be a while before we have the whole solution.
>
> If you don't have a specific concern with the patch I'll go ahead and
> commit
> it - I don't see it as dangerous for normal (non openpja.Multithreaded) use
> and we have at least one testcase which depends on it.
>
> -mike
>
> On Mon, Aug 16, 2010 at 8:50 AM, Rick Curtis <cu...@gmail.com> wrote:
>
> >
> > My biggest concern with that fix is that it isn't a complete fix for the
> > openjpa.Multithreaded property. It fixes the one one reported bug, but
> > there
> > are numerous others out there.
> >
> > I'd really like to see someone find some time to come up with a complete
> > multi threaded story for openjpa.
>
>

Re: svn commit: r985067 - /openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java

Posted by Rick Curtis <cu...@gmail.com>.
Go ahead and pull the trigger.

On Mon, Aug 16, 2010 at 1:20 PM, Michael Dick <mi...@gmail.com>wrote:

> I understand your concern about giving people a false sense of confidence -
> openjpa.Multithreaded requires more than just this fix. OTOH it's going to
> be a while before we have the whole solution.
>
> If you don't have a specific concern with the patch I'll go ahead and
> commit
> it - I don't see it as dangerous for normal (non openpja.Multithreaded) use
> and we have at least one testcase which depends on it.
>
> -mike
>
> On Mon, Aug 16, 2010 at 8:50 AM, Rick Curtis <cu...@gmail.com> wrote:
>
> >
> > My biggest concern with that fix is that it isn't a complete fix for the
> > openjpa.Multithreaded property. It fixes the one one reported bug, but
> > there
> > are numerous others out there.
> >
> > I'd really like to see someone find some time to come up with a complete
> > multi threaded story for openjpa.
>
>

Re: svn commit: r985067 - /openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java

Posted by Michael Dick <mi...@gmail.com>.
I understand your concern about giving people a false sense of confidence -
openjpa.Multithreaded requires more than just this fix. OTOH it's going to
be a while before we have the whole solution.

If you don't have a specific concern with the patch I'll go ahead and commit
it - I don't see it as dangerous for normal (non openpja.Multithreaded) use
and we have at least one testcase which depends on it.

-mike

On Mon, Aug 16, 2010 at 8:50 AM, Rick Curtis <cu...@gmail.com> wrote:

>
> My biggest concern with that fix is that it isn't a complete fix for the
> openjpa.Multithreaded property. It fixes the one one reported bug, but
> there
> are numerous others out there.
>
> I'd really like to see someone find some time to come up with a complete
> multi threaded story for openjpa.
> --
> View this message in context:
> http://openjpa.208410.n2.nabble.com/Re-svn-commit-r985067-openjpa-trunk-openjpa-slice-src-test-java-org-apache-openjpa-slice-TestQueryMua-tp5421603p5427904.html
> Sent from the OpenJPA Developers mailing list archive at Nabble.com.
>

Re: svn commit: r985067 - /openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java

Posted by Rick Curtis <cu...@gmail.com>.
My biggest concern with that fix is that it isn't a complete fix for the
openjpa.Multithreaded property. It fixes the one one reported bug, but there
are numerous others out there.

I'd really like to see someone find some time to come up with a complete
multi threaded story for openjpa. 
-- 
View this message in context: http://openjpa.208410.n2.nabble.com/Re-svn-commit-r985067-openjpa-trunk-openjpa-slice-src-test-java-org-apache-openjpa-slice-TestQueryMua-tp5421603p5427904.html
Sent from the OpenJPA Developers mailing list archive at Nabble.com.

Re: svn commit: r985067 - /openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java

Posted by Donald Woods <dw...@apache.org>.
Would like to get more feedback from Rick and others on OPENJPA-1716
first, since this test is exposing an issue that needs to be addressed.
I can live with the occasional test failures, as a constant reminder...
:-)  Thanks for taking a closer look at it.


-Donald


On 8/14/10 3:27 PM, Michael Dick wrote:
> The failing test makes use of openjpa.MultiThreaded, and reusing queries on
> 5 threads simultaneously. It looks like we're hitting OPENJPA-1716 or a
> similar locking issue. I was able to reproduce the problem by running
> TestQueryParameterEntry 4 times back to back - applying Rick's patch 'fixed
> it' or altered the timing enough so I couldn't hit it.
> 
> I know Rick had some reservations about 1716 - while we're looking at that
> fix should we just comment out the offending test method? It's generating a
> bit of noise in continuous test.
> 
> -mike
> 
> On Fri, Aug 13, 2010 at 4:42 PM, Michael Dick <mi...@gmail.com>wrote:
> 
>> I think it's more likely that it just didn't fix the problem.
>>
>> We're getting intermittent TimeoutExceptions from this testcase - run it a
>> second time and it passes.
>>
>> I naively thought that it was just a matter of load on the system so I
>> raised the timeout. I took a look at the latest TC builds and it looks like
>> they've passed - since my change anyway. The test still fails occasionally
>> though.
>>
>> I'm happy to revert the change if you're seeing different results.
>>
>> -mike
>>
>>
>>
>> On Fri, Aug 13, 2010 at 4:08 PM, Donald Woods <dw...@apache.org> wrote:
>>
>>> This seems to be causing a new failure on Derby under JDK5 and MSSQL
>>> 2008 under JDK6 -
>>>
>>> TestQueryMultiThreaded.testQueryParameterEntity(org.apache.openjpa.slice)
>>>    junit.framework.AssertionFailedError: Failed
>>> java.util.concurrent.TimeoutException
>>>    java.util.concurrent.TimeoutException
>>>    at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:228)
>>>    junit.framework.AssertionFailedError: Failed
>>> java.util.concurrent.TimeoutException
>>>    java.util.concurrent.TimeoutException
>>>    at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:228)
>>>    at java.util.concurrent.FutureTask.get(FutureTask.java:91)
>>>    at
>>>
>>> org.apache.openjpa.slice.TestQueryMultiThreaded.waitForTermination(TestQueryMultiThreaded.java:341)
>>>    at
>>>
>>> org.apache.openjpa.slice.TestQueryMultiThreaded.testQueryParameterEntity(TestQueryMultiThreaded.java:333)
>>>
>>>
>>> On 8/12/10 10:03 PM, mikedd@apache.org wrote:
>>>> Author: mikedd
>>>> Date: Fri Aug 13 02:03:48 2010
>>>> New Revision: 985067
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=985067&view=rev
>>>> Log:
>>>> Increase timeout value for slice testcase
>>>>
>>>> Modified:
>>>>
>>> openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
>>>>
>>>> Modified:
>>> openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
>>>> URL:
>>> http://svn.apache.org/viewvc/openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java?rev=985067&r1=985066&r2=985067&view=diff
>>>>
>>> ==============================================================================
>>>> ---
>>> openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
>>> (original)
>>>> +++
>>> openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
>>> Fri Aug 13 02:03:48 2010
>>>> @@ -49,6 +49,7 @@ public class TestQueryMultiThreaded exte
>>>>      private int VALUE_MIN = 100;
>>>>      private int VALUE_MAX = VALUE_MIN + POBJECT_COUNT - 1;
>>>>      private static int THREADS = 5;
>>>> +    private static int MAX_TIMEOUT = 300;
>>>>      private ExecutorService group;
>>>>      private Future[] futures;
>>>>
>>>> @@ -337,7 +338,7 @@ public class TestQueryMultiThreaded exte
>>>>          try {
>>>>              for (Future f : futures)
>>>>                  try {
>>>> -                    f.get(60, TimeUnit.SECONDS);
>>>> +                    f.get(MAX_TIMEOUT, TimeUnit.SECONDS);
>>>>                  } catch (TimeoutException te) {
>>>>                      fail("Failed " + te + "\r\n" + getStackDump(te));
>>>>                  } catch (ExecutionException e) {
>>>>
>>>>
>>>>
>>>
>>
>>
> 

Re: svn commit: r985067 - /openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java

Posted by Michael Dick <mi...@gmail.com>.
The failing test makes use of openjpa.MultiThreaded, and reusing queries on
5 threads simultaneously. It looks like we're hitting OPENJPA-1716 or a
similar locking issue. I was able to reproduce the problem by running
TestQueryParameterEntry 4 times back to back - applying Rick's patch 'fixed
it' or altered the timing enough so I couldn't hit it.

I know Rick had some reservations about 1716 - while we're looking at that
fix should we just comment out the offending test method? It's generating a
bit of noise in continuous test.

-mike

On Fri, Aug 13, 2010 at 4:42 PM, Michael Dick <mi...@gmail.com>wrote:

> I think it's more likely that it just didn't fix the problem.
>
> We're getting intermittent TimeoutExceptions from this testcase - run it a
> second time and it passes.
>
> I naively thought that it was just a matter of load on the system so I
> raised the timeout. I took a look at the latest TC builds and it looks like
> they've passed - since my change anyway. The test still fails occasionally
> though.
>
> I'm happy to revert the change if you're seeing different results.
>
> -mike
>
>
>
> On Fri, Aug 13, 2010 at 4:08 PM, Donald Woods <dw...@apache.org> wrote:
>
>> This seems to be causing a new failure on Derby under JDK5 and MSSQL
>> 2008 under JDK6 -
>>
>> TestQueryMultiThreaded.testQueryParameterEntity(org.apache.openjpa.slice)
>>    junit.framework.AssertionFailedError: Failed
>> java.util.concurrent.TimeoutException
>>    java.util.concurrent.TimeoutException
>>    at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:228)
>>    junit.framework.AssertionFailedError: Failed
>> java.util.concurrent.TimeoutException
>>    java.util.concurrent.TimeoutException
>>    at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:228)
>>    at java.util.concurrent.FutureTask.get(FutureTask.java:91)
>>    at
>>
>> org.apache.openjpa.slice.TestQueryMultiThreaded.waitForTermination(TestQueryMultiThreaded.java:341)
>>    at
>>
>> org.apache.openjpa.slice.TestQueryMultiThreaded.testQueryParameterEntity(TestQueryMultiThreaded.java:333)
>>
>>
>> On 8/12/10 10:03 PM, mikedd@apache.org wrote:
>> > Author: mikedd
>> > Date: Fri Aug 13 02:03:48 2010
>> > New Revision: 985067
>> >
>> > URL: http://svn.apache.org/viewvc?rev=985067&view=rev
>> > Log:
>> > Increase timeout value for slice testcase
>> >
>> > Modified:
>> >
>> openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
>> >
>> > Modified:
>> openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
>> > URL:
>> http://svn.apache.org/viewvc/openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java?rev=985067&r1=985066&r2=985067&view=diff
>> >
>> ==============================================================================
>> > ---
>> openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
>> (original)
>> > +++
>> openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
>> Fri Aug 13 02:03:48 2010
>> > @@ -49,6 +49,7 @@ public class TestQueryMultiThreaded exte
>> >      private int VALUE_MIN = 100;
>> >      private int VALUE_MAX = VALUE_MIN + POBJECT_COUNT - 1;
>> >      private static int THREADS = 5;
>> > +    private static int MAX_TIMEOUT = 300;
>> >      private ExecutorService group;
>> >      private Future[] futures;
>> >
>> > @@ -337,7 +338,7 @@ public class TestQueryMultiThreaded exte
>> >          try {
>> >              for (Future f : futures)
>> >                  try {
>> > -                    f.get(60, TimeUnit.SECONDS);
>> > +                    f.get(MAX_TIMEOUT, TimeUnit.SECONDS);
>> >                  } catch (TimeoutException te) {
>> >                      fail("Failed " + te + "\r\n" + getStackDump(te));
>> >                  } catch (ExecutionException e) {
>> >
>> >
>> >
>>
>
>

Re: svn commit: r985067 - /openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java

Posted by Michael Dick <mi...@gmail.com>.
I think it's more likely that it just didn't fix the problem.

We're getting intermittent TimeoutExceptions from this testcase - run it a
second time and it passes.

I naively thought that it was just a matter of load on the system so I
raised the timeout. I took a look at the latest TC builds and it looks like
they've passed - since my change anyway. The test still fails occasionally
though.

I'm happy to revert the change if you're seeing different results.

-mike


On Fri, Aug 13, 2010 at 4:08 PM, Donald Woods <dw...@apache.org> wrote:

> This seems to be causing a new failure on Derby under JDK5 and MSSQL
> 2008 under JDK6 -
>
> TestQueryMultiThreaded.testQueryParameterEntity(org.apache.openjpa.slice)
>    junit.framework.AssertionFailedError: Failed
> java.util.concurrent.TimeoutException
>    java.util.concurrent.TimeoutException
>    at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:228)
>    junit.framework.AssertionFailedError: Failed
> java.util.concurrent.TimeoutException
>    java.util.concurrent.TimeoutException
>    at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:228)
>    at java.util.concurrent.FutureTask.get(FutureTask.java:91)
>    at
>
> org.apache.openjpa.slice.TestQueryMultiThreaded.waitForTermination(TestQueryMultiThreaded.java:341)
>    at
>
> org.apache.openjpa.slice.TestQueryMultiThreaded.testQueryParameterEntity(TestQueryMultiThreaded.java:333)
>
>
> On 8/12/10 10:03 PM, mikedd@apache.org wrote:
> > Author: mikedd
> > Date: Fri Aug 13 02:03:48 2010
> > New Revision: 985067
> >
> > URL: http://svn.apache.org/viewvc?rev=985067&view=rev
> > Log:
> > Increase timeout value for slice testcase
> >
> > Modified:
> >
> openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
> >
> > Modified:
> openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
> > URL:
> http://svn.apache.org/viewvc/openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java?rev=985067&r1=985066&r2=985067&view=diff
> >
> ==============================================================================
> > ---
> openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
> (original)
> > +++
> openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
> Fri Aug 13 02:03:48 2010
> > @@ -49,6 +49,7 @@ public class TestQueryMultiThreaded exte
> >      private int VALUE_MIN = 100;
> >      private int VALUE_MAX = VALUE_MIN + POBJECT_COUNT - 1;
> >      private static int THREADS = 5;
> > +    private static int MAX_TIMEOUT = 300;
> >      private ExecutorService group;
> >      private Future[] futures;
> >
> > @@ -337,7 +338,7 @@ public class TestQueryMultiThreaded exte
> >          try {
> >              for (Future f : futures)
> >                  try {
> > -                    f.get(60, TimeUnit.SECONDS);
> > +                    f.get(MAX_TIMEOUT, TimeUnit.SECONDS);
> >                  } catch (TimeoutException te) {
> >                      fail("Failed " + te + "\r\n" + getStackDump(te));
> >                  } catch (ExecutionException e) {
> >
> >
> >
>

Re: svn commit: r985067 - /openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java

Posted by Donald Woods <dw...@apache.org>.
This seems to be causing a new failure on Derby under JDK5 and MSSQL
2008 under JDK6 -

TestQueryMultiThreaded.testQueryParameterEntity(org.apache.openjpa.slice)
    junit.framework.AssertionFailedError: Failed
java.util.concurrent.TimeoutException
    java.util.concurrent.TimeoutException
    at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:228)
    junit.framework.AssertionFailedError: Failed
java.util.concurrent.TimeoutException
    java.util.concurrent.TimeoutException
    at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:228)
    at java.util.concurrent.FutureTask.get(FutureTask.java:91)
    at
org.apache.openjpa.slice.TestQueryMultiThreaded.waitForTermination(TestQueryMultiThreaded.java:341)
    at
org.apache.openjpa.slice.TestQueryMultiThreaded.testQueryParameterEntity(TestQueryMultiThreaded.java:333)


On 8/12/10 10:03 PM, mikedd@apache.org wrote:
> Author: mikedd
> Date: Fri Aug 13 02:03:48 2010
> New Revision: 985067
> 
> URL: http://svn.apache.org/viewvc?rev=985067&view=rev
> Log:
> Increase timeout value for slice testcase
> 
> Modified:
>     openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
> 
> Modified: openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java
> URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java?rev=985067&r1=985066&r2=985067&view=diff
> ==============================================================================
> --- openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java (original)
> +++ openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java Fri Aug 13 02:03:48 2010
> @@ -49,6 +49,7 @@ public class TestQueryMultiThreaded exte
>      private int VALUE_MIN = 100;
>      private int VALUE_MAX = VALUE_MIN + POBJECT_COUNT - 1;
>      private static int THREADS = 5;
> +    private static int MAX_TIMEOUT = 300;
>      private ExecutorService group; 
>      private Future[] futures;
>  
> @@ -337,7 +338,7 @@ public class TestQueryMultiThreaded exte
>          try {
>              for (Future f : futures)
>                  try {
> -                    f.get(60, TimeUnit.SECONDS);
> +                    f.get(MAX_TIMEOUT, TimeUnit.SECONDS);
>                  } catch (TimeoutException te) {
>                      fail("Failed " + te + "\r\n" + getStackDump(te));
>                  } catch (ExecutionException e) {
> 
> 
>