You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by no...@apache.org on 2020/12/29 12:52:10 UTC

[buildstream] 03/03: Fix bugs and style issues with pylint

This is an automated email from the ASF dual-hosted git repository.

not-in-ldap pushed a commit to branch 239-use-pylint-for-linting
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit 9ab3274393bda6c25e27c84210a97444cd4d4be4
Author: Tristan Maat <tr...@codethink.co.uk>
AuthorDate: Thu Feb 8 18:15:13 2018 +0000

    Fix bugs and style issues with pylint
---
 .gitlab-ci.yml           | 3 ---
 buildstream/_pipeline.py | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 953ede7..ca297a4 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -72,10 +72,7 @@ linting:
   variables:
     PYTEST_ADDOPTS: "--color=yes"
   script:
-    - cd dist && ./unpack.sh && cd buildstream
     - python3 setup.py test --addopts '--no-cov --pylint --pep8 -m "pep8 or pylint"'
-  dependencies:
-    - source_dist
 
 # Run premerge commits
 #
diff --git a/buildstream/_pipeline.py b/buildstream/_pipeline.py
index 9ce97ce..85c3574 100644
--- a/buildstream/_pipeline.py
+++ b/buildstream/_pipeline.py
@@ -687,7 +687,7 @@ class Pipeline():
 
         if workspace_dir is None:
             raise PipelineError("Workspace '{}' is currently not defined"
-                                .format(target.name + " - " + str(source_index)))
+                                .format(target.name))
 
         self.close_workspace(True)