You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/10/29 09:43:18 UTC

[GitHub] [kafka] dajac commented on a change in pull request #11448: KAFKA-13417; Ensure dynamic reconfigurations set old config properly

dajac commented on a change in pull request #11448:
URL: https://github.com/apache/kafka/pull/11448#discussion_r739089348



##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1341,7 +1341,7 @@ object KafkaConfig {
     fromProps(props, doLog)
   }
 
-  def apply(props: java.util.Map[_, _]): KafkaConfig = new KafkaConfig(props, true)
+  def apply(props: java.util.Map[_, _], doLog: Boolean = true): KafkaConfig = new KafkaConfig(props, true)

Review comment:
       Did you aim to pass 'doLog' to 'KafkaConfig' as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org