You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "alievmirza (via GitHub)" <gi...@apache.org> on 2023/05/18 15:09:52 UTC
[GitHub] [ignite-3] alievmirza opened a new pull request, #2089: IGNITE-19443 Empty data nodes are not propagated to pending assignments after filtering
alievmirza opened a new pull request, #2089:
URL: https://github.com/apache/ignite-3/pull/2089
https://issues.apache.org/jira/browse/IGNITE-19443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2089: IGNITE-19443 Empty data nodes are not propagated to pending assignments after filtering
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc commented on code in PR #2089:
URL: https://github.com/apache/ignite-3/pull/2089#discussion_r1198039154
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandler.java:
##########
@@ -230,6 +230,10 @@ private CompletableFuture<Boolean> handleAlterZone(AlterZoneSetCommand cmd) {
zoneCfgBuilder.dataNodesAutoAdjustScaleUp(cmd.dataNodesAutoAdjustScaleUp());
}
+ if (cmd.replicas() != null) {
Review Comment:
What's that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2089: IGNITE-19443 Empty data nodes are not propagated to pending assignments after filtering
Posted by "alievmirza (via GitHub)" <gi...@apache.org>.
alievmirza commented on code in PR #2089:
URL: https://github.com/apache/ignite-3/pull/2089#discussion_r1198257291
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandler.java:
##########
@@ -230,6 +230,10 @@ private CompletableFuture<Boolean> handleAlterZone(AlterZoneSetCommand cmd) {
zoneCfgBuilder.dataNodesAutoAdjustScaleUp(cmd.dataNodesAutoAdjustScaleUp());
}
+ if (cmd.replicas() != null) {
Review Comment:
I've added this for supporting altering replicas for a zone through SQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sanpwc merged pull request #2089: IGNITE-19443 Empty data nodes are not propagated to pending assignments after filtering
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc merged PR #2089:
URL: https://github.com/apache/ignite-3/pull/2089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org