[GitHub] storm pull request: STORM-603 Log errors when required kafka param...

[harshach <gi...@git.apache.org>]

Github user harshach commented on a diff in the pull request:

    https://github.com/apache/storm/pull/361#discussion_r22435307
  
    --- Diff: external/storm-kafka/src/jvm/storm/kafka/DynamicBrokersReader.java ---
    @@ -149,4 +158,19 @@ private Broker getBrokerHost(byte[] contents) {
             }
         }
     
    +    private void validateConfig(final Map conf) {
    +        if(conf.get(Config.STORM_ZOOKEEPER_SESSION_TIMEOUT) == null) {
    --- End diff --
    
    These are all storm configs , even if user didn't pass these or set in storm.yaml there are defaults . So not sure checking for this necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---