You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/07/26 17:43:54 UTC
[kudu-CR] [util] update on ParseVersion()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11060
Change subject: [util] update on ParseVersion()
......................................................................
[util] update on ParseVersion()
This changelist updates implementation of the kudu::ParseVersion()
utility function to recognize and successfully parse version strings
like '1.8.0-cdh6.x-SNAPSHOT'.
Version::ToString() implementation changed to return
'canonical' representation of the parsed version string. Added
corresponding unit tests.
This patch also fixes KUDU-2511.
This is a follow-up for c12e63528a2f2c265136e702a48cbc6c93b7f2fd.
Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
---
M src/kudu/util/version_util-test.cc
M src/kudu/util/version_util.cc
M src/kudu/util/version_util.h
3 files changed, 83 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/11060/1
--
To view, visit http://gerrit.cloudera.org:8080/11060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [util] update on ParseVersion()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11060
to look at the new patch set (#3).
Change subject: [util] update on ParseVersion()
......................................................................
[util] update on ParseVersion()
This changelist updates implementation of the kudu::ParseVersion()
utility function to recognize and successfully parse version strings
like '1.8.0-cdh6.x-SNAPSHOT'.
Version::ToString() implementation changed to return
'canonical' representation of the parsed version string. Added
corresponding unit tests.
This patch also fixes KUDU-2511.
This is a follow-up for c12e63528a2f2c265136e702a48cbc6c93b7f2fd.
Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
---
M src/kudu/util/version_util-test.cc
M src/kudu/util/version_util.cc
M src/kudu/util/version_util.h
3 files changed, 98 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/11060/3
--
To view, visit http://gerrit.cloudera.org:8080/11060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [util] update on ParseVersion()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11060 )
Change subject: [util] update on ParseVersion()
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [util] update on ParseVersion()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11060 )
Change subject: [util] update on ParseVersion()
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11060/2/src/kudu/util/version_util-test.cc
File src/kudu/util/version_util-test.cc:
http://gerrit.cloudera.org:8080/#/c/11060/2/src/kudu/util/version_util-test.cc@33
PS2, Line 33:
: TEST(VersionUtilTest, TestVersion) {
: const vector<pair<Version, string>> good_test_cases = {
> Would it make sense to add a small test that parses the current version of
Sounds like a great idea! Done.
http://gerrit.cloudera.org:8080/#/c/11060/2/src/kudu/util/version_util.h
File src/kudu/util/version_util.h:
http://gerrit.cloudera.org:8080/#/c/11060/2/src/kudu/util/version_util.h@39
PS2, Line 39: Return 'canonical' version string.
> Hrm, how is this different than 'raw_version'?
I think it's easier to point to those tests cases in version_util-test.cc: https://gerrit.cloudera.org/#/c/11060/2/src/kudu/util/version_util-test.cc@51
In short, leading and trailing whitespaces are trimmed, and SimpleItoa() has its own quirks in parsing the input.
The 'canonical' version string is just concatenation of the parsed information back into a string.
--
To view, visit http://gerrit.cloudera.org:8080/11060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 26 Jul 2018 23:19:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] [util] update on ParseVersion()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11060 )
Change subject: [util] update on ParseVersion()
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11060/2/src/kudu/util/version_util-test.cc
File src/kudu/util/version_util-test.cc:
http://gerrit.cloudera.org:8080/#/c/11060/2/src/kudu/util/version_util-test.cc@33
PS2, Line 33:
: TEST(VersionUtilTest, TestVersion) {
: const vector<pair<Version, string>> good_test_cases = {
Would it make sense to add a small test that parses the current version of Kudu and makes sure we get a major and minor version back?
http://gerrit.cloudera.org:8080/#/c/11060/2/src/kudu/util/version_util.h
File src/kudu/util/version_util.h:
http://gerrit.cloudera.org:8080/#/c/11060/2/src/kudu/util/version_util.h@39
PS2, Line 39: Return 'canonical' version string.
Hrm, how is this different than 'raw_version'?
--
To view, visit http://gerrit.cloudera.org:8080/11060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 26 Jul 2018 22:35:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] [util] update on ParseVersion()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11060
to look at the new patch set (#2).
Change subject: [util] update on ParseVersion()
......................................................................
[util] update on ParseVersion()
This changelist updates implementation of the kudu::ParseVersion()
utility function to recognize and successfully parse version strings
like '1.8.0-cdh6.x-SNAPSHOT'.
Version::ToString() implementation changed to return
'canonical' representation of the parsed version string. Added
corresponding unit tests.
This patch also fixes KUDU-2511.
This is a follow-up for c12e63528a2f2c265136e702a48cbc6c93b7f2fd.
Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
---
M src/kudu/util/version_util-test.cc
M src/kudu/util/version_util.cc
M src/kudu/util/version_util.h
3 files changed, 83 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/11060/2
--
To view, visit http://gerrit.cloudera.org:8080/11060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [util] update on ParseVersion()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11060 )
Change subject: [util] update on ParseVersion()
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 28 Jul 2018 17:44:31 +0000
Gerrit-HasComments: No
[kudu-CR] [util] update on ParseVersion()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11060 )
Change subject: [util] update on ParseVersion()
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [util] update on ParseVersion()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11060 )
Change subject: [util] update on ParseVersion()
......................................................................
Patch Set 3: Verified+1
Unrelated flake in org.apache.kudu.spark.kudu.DefaultSourceTest.socket read timeout propagation
--
To view, visit http://gerrit.cloudera.org:8080/11060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 27 Jul 2018 00:03:18 +0000
Gerrit-HasComments: No
[kudu-CR] [util] update on ParseVersion()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11060 )
Change subject: [util] update on ParseVersion()
......................................................................
[util] update on ParseVersion()
This changelist updates implementation of the kudu::ParseVersion()
utility function to recognize and successfully parse version strings
like '1.8.0-cdh6.x-SNAPSHOT'.
Version::ToString() implementation changed to return
'canonical' representation of the parsed version string. Added
corresponding unit tests.
This patch also fixes KUDU-2511.
This is a follow-up for c12e63528a2f2c265136e702a48cbc6c93b7f2fd.
Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
Reviewed-on: http://gerrit.cloudera.org:8080/11060
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/util/version_util-test.cc
M src/kudu/util/version_util.cc
M src/kudu/util/version_util.h
3 files changed, 98 insertions(+), 30 deletions(-)
Approvals:
Alexey Serbin: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [util] update on ParseVersion()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11060 )
Change subject: [util] update on ParseVersion()
......................................................................
Patch Set 2: Verified+1
Unrelated flakes in:
org.apache.kudu.client.ITClientStress.testManyShortClientsGeneratingScanTokens
org.apache.kudu.backup.TestKuduBackup.Random Backup and Restore
--
To view, visit http://gerrit.cloudera.org:8080/11060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b200d0529cb4471e4e855b88bfdb2ff2f346bf
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 26 Jul 2018 21:31:13 +0000
Gerrit-HasComments: No