(datafusion) 01/01: chore: gate `internal_datafusion_err` import behind the `proto` feature (#23075)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-23075-48a5e21263d02207ac5b888728a19f8e8bc3ca19
in repository https://gitbox.apache.org/repos/asf/datafusion.git

commit dc92bb88dbe5bdcc3e58a6d57e8c697583b99de3
Author: Phoenix <Ph...@163.com>
AuthorDate: Tue Jun 23 18:32:49 2026 +0800

    chore: gate `internal_datafusion_err` import behind the `proto` feature (#23075)
    
    ## Which issue does this PR close?
    
    N/A — a trivial build-warning fix, no tracking issue.
    
    ## Rationale for this change
    
    Building `datafusion-physical-expr` without the `proto` feature emits an
    `unused import` warning:
    
    ```
    warning: unused import: `internal_datafusion_err`
      --> datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs:26
    ```
    
    `internal_datafusion_err` is only referenced inside
    `impl DynamicFilterPhysicalExpr { fn try_from_proto(..) }`, which is
    itself gated
    behind `#[cfg(feature = "proto")]`. The import was unconditional, so it
    became
    dead whenever `proto` is disabled.
    
    ## What changes are included in this PR?
    
    Move the `internal_datafusion_err` import behind `#[cfg(feature =
    "proto")]` so it
    is compiled only when its sole use site is, matching the existing gate
    on the
    `try_from_proto` impl block.
    
    ## Are these changes tested?
    
    No new tests — this is a compile-time-only change. It is exercised by
    existing CI,
    which builds the crate both with and without the `proto` feature; the
    warning
    (promoted to an error under `-D warnings`) no longer fires.
    
    ## Are there any user-facing changes?
    
    No.
    
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    
    Signed-off-by: Jiawei Zhao <Ph...@163.com>
---
 datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs b/datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs
index 0669913c32..ce81a22094 100644
--- a/datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs
+++ b/datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs
@@ -22,10 +22,13 @@ use tokio::sync::watch;
 
 use crate::PhysicalExpr;
 use arrow::datatypes::{DataType, Schema};
+#[cfg(feature = "proto")]
+use datafusion_common::internal_datafusion_err;
 use datafusion_common::{
-    Result, internal_datafusion_err,
+    Result,
     tree_node::{Transformed, TransformedResult, TreeNode},
 };
+
 use datafusion_expr::ColumnarValue;
 use datafusion_physical_expr_common::physical_expr::DynHash;
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org