You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by acton393 <gi...@git.apache.org> on 2018/02/12 09:44:41 UTC

[GitHub] incubator-weex pull request #1029: [WEEX-218][iOS] support leftGap and right...

GitHub user acton393 opened a pull request:

    https://github.com/apache/incubator-weex/pull/1029

    [WEEX-218][iOS] support leftGap and rightGap for waterfall component

    try case:  http://dotwe.org/vue/16ca2c8a9b0d7298f67bc0e7a1314c15
    
    support leftGap and rightGap for waterfall component, thus you 
    can specify the leftGap and rightGap for cell inside waterfall.
    
    feature:218
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/acton393/incubator-weex ios-improvementforwaterfall

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1029.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1029
    
----
commit 3c72523daf35e69f9f8e3ab0a5f489b5a21bc528
Author: acton393 <zh...@...>
Date:   2018-02-12T09:39:51Z

    [WEEX-218][iOS] support leftGap and rightGap for waterfall component
    
    support leftGap and rightGap for waterfall component, thus you can specify
     the leftGap and rightGap for cell inside waterfall component.
    
    feature:218

----


---

[GitHub] incubator-weex issue #1029: [WEEX-218][iOS] support leftGap and rightGap for...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1029
  
    
    <!--
      0 failure: 
      0 warning: 
      2 messages
      
    -->
    
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>has no jsfm file changed.</td>
        </tr>
      
    <tr>
          <td>:book:</td>
          <td>jsfm test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---

[GitHub] incubator-weex pull request #1029: [WEEX-218][iOS] support leftGap and right...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1029


---