You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/02 04:01:58 UTC

[GitHub] [spark] ueshin commented on a change in pull request #28957: [WIP][SPARK-32138] Drop Python 2.7, 3.4 and 3.5

ueshin commented on a change in pull request #28957:
URL: https://github.com/apache/spark/pull/28957#discussion_r448615071



##########
File path: python/pyspark/mllib/clustering.py
##########
@@ -17,20 +17,12 @@
 
 import sys
 import array as pyarray
-import warnings
-
-if sys.version > '3':
-    xrange = range
-    basestring = str
-
 from math import exp, log
+from collections import namedtuple
 
 from numpy import array, random, tile
 
-from collections import namedtuple
-
-from pyspark import SparkContext, since
-from pyspark.rdd import RDD, ignore_unicode_prefix
+from pyspark import SparkContext, since, RDD

Review comment:
       nit: Why changed to import `RDD` from `pyspark` instead of `pyspark.rdd`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org