You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by iv...@apache.org on 2010/08/13 01:46:37 UTC

svn commit: r985045 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java

Author: ivaynberg
Date: Thu Aug 12 23:46:36 2010
New Revision: 985045

URL: http://svn.apache.org/viewvc?rev=985045&view=rev
Log:
fixed problem with form hidden fields

Modified:
    wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java?rev=985045&r1=985044&r2=985045&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java Thu Aug 12 23:46:36 2010
@@ -48,8 +48,8 @@ import org.apache.wicket.util.lang.Bytes
 import org.apache.wicket.util.string.AppendingStringBuffer;
 import org.apache.wicket.util.string.Strings;
 import org.apache.wicket.util.string.interpolator.MapVariableInterpolator;
-import org.apache.wicket.util.upload.FileUploadException;
 import org.apache.wicket.util.upload.FileUploadBase.SizeLimitExceededException;
+import org.apache.wicket.util.upload.FileUploadException;
 import org.apache.wicket.util.visit.IVisit;
 import org.apache.wicket.util.visit.IVisitor;
 import org.apache.wicket.validation.IValidatorAddListener;
@@ -133,6 +133,8 @@ import org.slf4j.LoggerFactory;
  */
 public class Form<T> extends WebMarkupContainer implements IFormSubmitListener, IHeaderContributor
 {
+	private static final String HIDDEN_DIV_START = "<div style=\"width:0px;height:0px;position:absolute;left:-100px;top:-100px;overflow:hidden\">";
+
 	/**
 	 * Visitor used for validation
 	 * 
@@ -589,8 +591,12 @@ public class Form<T> extends WebMarkupCo
 	{
 		Form<?> root = getRootForm();
 		return new AppendingStringBuffer("document.getElementById('").append(
-			root.getHiddenFieldId()).append("').value='").append(url).append(
-			"';document.getElementById('").append(root.getMarkupId()).append("').submit();");
+			root.getHiddenFieldId())
+			.append("').value='")
+			.append(url)
+			.append("';document.getElementById('")
+			.append(root.getMarkupId())
+			.append("').submit();");
 	}
 
 	/**
@@ -1157,7 +1163,7 @@ public class Form<T> extends WebMarkupCo
 		AppendingStringBuffer buffer = new AppendingStringBuffer();
 
 		// div that is not visible (but not display:none either)
-		buffer.append("<div style=\"width:0px;height:0px;position:absolute;left:-100px;top:-100px;overflow:hidden\">");
+		buffer.append(HIDDEN_DIV_START);
 
 		// add an empty textfield (otherwise IE doesn't work)
 		buffer.append("<input type=\"text\" autocomplete=\"false\"/>");
@@ -1578,8 +1584,9 @@ public class Form<T> extends WebMarkupCo
 			String nameAndId = getHiddenFieldId();
 
 			// render the hidden field
-			AppendingStringBuffer buffer = new AppendingStringBuffer(
-				"<div style=\"display:none\"><input type=\"hidden\" name=\"").append(nameAndId)
+			AppendingStringBuffer buffer = new AppendingStringBuffer(HIDDEN_DIV_START).append(
+				"<input type=\"hidden\" name=\"")
+				.append(nameAndId)
 				.append("\" id=\"")
 				.append(nameAndId)
 				.append("\" />");
@@ -1623,8 +1630,11 @@ public class Form<T> extends WebMarkupCo
 		{
 			String[] pair = params[j].split("=");
 
-			buffer.append("<input type=\"hidden\" name=\"").append(recode(pair[0])).append(
-				"\" value=\"").append(pair.length > 1 ? recode(pair[1]) : "").append("\" />");
+			buffer.append("<input type=\"hidden\" name=\"")
+				.append(recode(pair[0]))
+				.append("\" value=\"")
+				.append(pair.length > 1 ? recode(pair[1]) : "")
+				.append("\" />");
 		}
 	}