You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/12 13:44:58 UTC
[GitHub] [cordova-common] dpa99c opened a new pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)
dpa99c opened a new pull request #148:
URL: https://github.com/apache/cordova-common/pull/148
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
When multiple plist files exists in a cordova-ios project (e.g. due to a plugin containing `<podspec>`), ConfigFile was updated under CB-5989 to select the app plist as the target for changes destined for *-Info.plist.
However, the change made under CB-5989 incorrectly constructed the path to the app plist by omitting the project name subdirectory from the path, causing the fix to fail to work.
This bug is outlined in #144.
### Description
<!-- Describe your changes in detail -->
This commit fixes this by correcting the constructed path to the app plist.
### Testing
<!-- Please describe in detail how you tested your changes. -->
I've created a repo containing a test Cordova project which reproduces the various scenarios to illustrate the issue:
https://github.com/dpa99c/cordova-common-issue-144
Details of these scenarios can be found in [this comment](https://github.com/apache/cordova-common/issues/144#issuecomment-643215608).
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change **N/A**
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary **N/A**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] dpa99c merged pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)
Posted by GitBox <gi...@apache.org>.
dpa99c merged pull request #148:
URL: https://github.com/apache/cordova-common/pull/148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] erisu edited a comment on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643283534
I don't see any passing tests.
Two test, ubuntu, failed and caused GitHub Actions to cancelled the other 4 tests with out either starting or finishing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] erisu commented on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643283534
I don't see any passing tests.
Two test, ubuntu, failed and caused GitHub Actions to cancelled the other 4 tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] erisu edited a comment on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643279209
Looks like a test file though might need to be updated.
This line specifically will need the change:
```javascript
const expectedPlistPath = `${projName}-Info.plist`;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] codecov-commenter edited a comment on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643286829
# [Codecov](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=h1) Report
> Merging [#148](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-common/commit/b5ba4db84b993e1c31f0d73a1d37d6a7f92b845d&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 88.23% 88.24% +0.01%
==========================================
Files 20 20
Lines 1173 1174 +1
==========================================
+ Hits 1035 1036 +1
Misses 138 138
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/ConfigChanges/ConfigFile.js](https://codecov.io/gh/apache/cordova-common/pull/148/diff?src=pr&el=tree#diff-c3JjL0NvbmZpZ0NoYW5nZXMvQ29uZmlnRmlsZS5qcw==) | `92.23% <100.00%> (+0.07%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=footer). Last update [b5ba4db...a18bf0e](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] erisu edited a comment on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643279209
Looks like a test file though might need to be updated.
Looks like its this line that will need to be changed.
```javascript
const expectedPlistPath = `${projName}-Info.plist`;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] dpa99c commented on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)
Posted by GitBox <gi...@apache.org>.
dpa99c commented on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643282320
Interesting that the ubuntu tests failed but windows & osx passed.
Is there some platform-specific difference between the paths on windows/osx vs ubuntu?
This may explain why CB-5989 failed to fix the issue on osx?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] erisu edited a comment on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643283534
I don't see any passing tests.
Two test, ubuntu, had failed and caused GitHub Actions to trigger the cancel procedure of the other four remaining tests with out either starting or finishing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] erisu commented on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643279209
Looks like a test file though might need to be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] erisu edited a comment on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643279209
Looks like a test file though might need to be updated. Could be some hard-coded mocked test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] codecov-commenter commented on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643286829
# [Codecov](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=h1) Report
> Merging [#148](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-common/commit/b5ba4db84b993e1c31f0d73a1d37d6a7f92b845d&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 88.23% 88.24% +0.01%
==========================================
Files 20 20
Lines 1173 1174 +1
==========================================
+ Hits 1035 1036 +1
Misses 138 138
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/ConfigChanges/ConfigFile.js](https://codecov.io/gh/apache/cordova-common/pull/148/diff?src=pr&el=tree#diff-c3JjL0NvbmZpZ0NoYW5nZXMvQ29uZmlnRmlsZS5qcw==) | `92.23% <100.00%> (+0.07%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=footer). Last update [b5ba4db...a18bf0e](https://codecov.io/gh/apache/cordova-common/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] dpa99c commented on pull request #148: fix: resolve correct path to app info plist when multiple plist files are present (#144)
Posted by GitBox <gi...@apache.org>.
dpa99c commented on pull request #148:
URL: https://github.com/apache/cordova-common/pull/148#issuecomment-643284186
> I don't see any passing tests.
>
> Two test, ubuntu, failed and caused GitHub Actions to cancelled the other 4 tests.
ah, yes, I misread the cancelled as passed (no big red X)
will run/fix the tests locally and update my branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org