[jira] [Commented] (OPENNLP-1392) POS models created with 2.x are trained differently

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624565#comment-17624565 ] 

ASF GitHub Bot commented on OPENNLP-1392:
-----------------------------------------

jzonthemtn opened a new pull request, #429:
URL: https://github.com/apache/opennlp/pull/429

   Changing conditional to be for version 1.x to fix 2.x POS models
   
   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [X] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [X] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [X] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
   




> POS models created with 2.x are trained differently
> ---------------------------------------------------
>
>                 Key: OPENNLP-1392
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1392
>             Project: OpenNLP
>          Issue Type: Task
>          Components: POS Tagger
>    Affects Versions: 2.0.0
>            Reporter: Jeff Zemerick
>            Assignee: Jeff Zemerick
>            Priority: Major
>
> POS models that are trained with version 2.x are trained with different parameters than what's expected due to a conditional in POSTaggerFactory that looked at the minor revision. This conditional assumes the major version is 1.
> The conditional needs updated to check the major version, too.
> To reproduce, run the ConllXPosTaggerEval.evalDanishMaxentGis() test.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)