You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Eric Shu <es...@pivotal.io> on 2016/11/10 20:59:01 UTC
Review Request 53657: GEODE-2091: Do not return false when
containsValueForKey call failed in transaction due to BucketNotFoundException
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53657/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Darrel Schneider, and Swapnil Bawaskar.
Repository: geode
Description
-------
Correctly handle exception to fail the exception instead of returning null.
Add check for colocated buckets so that correct TrasactionException can be thrown.
Fix containsKey method call as well.
Add test cases in dunit test.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/TXStateStub.java a6c78f2
geode-core/src/main/java/org/apache/geode/internal/cache/tx/PartitionedTXRegionStub.java 0e9c128
geode-core/src/test/java/org/apache/geode/disttx/PRDistTXDUnitTest.java 150fe33
geode-core/src/test/java/org/apache/geode/disttx/PRDistTXWithVersionsDUnitTest.java 8ff1d94
geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java 2122960
Diff: https://reviews.apache.org/r/53657/diff/
Testing
-------
precheckin.
Thanks,
Eric Shu
Re: Review Request 53657: GEODE-2091: Do not return false when
containsValueForKey call failed in transaction due to BucketNotFoundException
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53657/#review155649
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Nov. 10, 2016, 12:59 p.m., Eric Shu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53657/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2016, 12:59 p.m.)
>
>
> Review request for geode, anilkumar gingade, Darrel Schneider, and Swapnil Bawaskar.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Correctly handle exception to fail the exception instead of returning null.
> Add check for colocated buckets so that correct TrasactionException can be thrown.
> Fix containsKey method call as well.
> Add test cases in dunit test.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/TXStateStub.java a6c78f2
> geode-core/src/main/java/org/apache/geode/internal/cache/tx/PartitionedTXRegionStub.java 0e9c128
> geode-core/src/test/java/org/apache/geode/disttx/PRDistTXDUnitTest.java 150fe33
> geode-core/src/test/java/org/apache/geode/disttx/PRDistTXWithVersionsDUnitTest.java 8ff1d94
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java 2122960
>
> Diff: https://reviews.apache.org/r/53657/diff/
>
>
> Testing
> -------
>
> precheckin.
>
>
> Thanks,
>
> Eric Shu
>
>