[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6951: Add support for SigV4 request signing to REST Catalog requests

["danielcweeks (via GitHub)" <gi...@apache.org>]

danielcweeks commented on code in PR #6951:
URL: https://github.com/apache/iceberg/pull/6951#discussion_r1119370679


##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -64,13 +71,31 @@ public class HTTPClient implements RESTClient {
   private final String uri;
   private final CloseableHttpClient httpClient;
   private final ObjectMapper mapper;
-  private final Map<String, String> baseHeaders;

Review Comment:
   Default headers are now built as part of the client builder.  This should have no affect on behavior since they are immutable in this implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org