[jira] Created: (FELIX-886) HTTPRequestForIcon is incompatible with Windows Media Player 11

["Bruce Jackson (JIRA)" <ji...@apache.org>]

HTTPRequestForIcon is incompatible with Windows Media Player 11
---------------------------------------------------------------

                 Key: FELIX-886
                 URL: https://issues.apache.org/jira/browse/FELIX-886
             Project: Felix
          Issue Type: Bug
          Components: UPnP Subproject
    Affects Versions: felix-1.4.1
         Environment: Mac or PC
            Reporter: Bruce Jackson


Using the felix UPnP base driver, I'm unable to retrieve icons for Windows
Media Player UPnP content sources.

I've followed the code through, and I come to the class:

org.apache.felix.upnp.basedriver.importer.util.HTTPRequestForIcon

...which is where the trouble is.

This class contains a method:

public InputStream getInputStream()

... Which starts with the comment:

//TODO we should speak about that

... Never a good sign :-) ! I'm trying to understand why the code manually
constructs the HTTP request and does everything at the socket level, rather
than simply:

URLConnection conn = url.openConnection();
return conn.getInputStream();

I've changed this in my local copy of the base driver, and tested it, and it
works fine. So, either this is a bit of old code that should be fixed, OR
there is a good reason to not use the JDK URLConnection class that somebody
might be aware of.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.