You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2017/05/01 21:07:29 UTC
Review Request 58892: Added C++11 scoped enumeration to style guide.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58892/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
We've been using it for new code now.
Diffs
-----
docs/c++-style-guide.md ccb81f48e2edc9c1e7c328cc26e44d658b4c43b4
Diff: https://reviews.apache.org/r/58892/diff/1/
Testing
-------
Markdown viewer.
Thanks,
Jiang Yan Xu
Re: Review Request 58892: Added C++11 scoped enumeration to style
guide.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58892/#review174101
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On May 2, 2017, 3:11 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58892/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 3:11 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We've been using it for new code now.
>
>
> Diffs
> -----
>
> docs/c++-style-guide.md ccb81f48e2edc9c1e7c328cc26e44d658b4c43b4
>
>
> Diff: https://reviews.apache.org/r/58892/diff/2/
>
>
> Testing
> -------
>
> Markdown viewer.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 58892: Added C++11 scoped enumeration to style
guide.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58892/#review174122
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58892]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 2, 2017, 10:11 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58892/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 10:11 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We've been using it for new code now.
>
>
> Diffs
> -----
>
> docs/c++-style-guide.md ccb81f48e2edc9c1e7c328cc26e44d658b4c43b4
>
>
> Diff: https://reviews.apache.org/r/58892/diff/2/
>
>
> Testing
> -------
>
> Markdown viewer.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 58892: Added C++11 scoped enumeration to style
guide.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58892/
-----------------------------------------------------------
(Updated May 2, 2017, 3:11 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Comments.
Repository: mesos
Description
-------
We've been using it for new code now.
Diffs (updated)
-----
docs/c++-style-guide.md ccb81f48e2edc9c1e7c328cc26e44d658b4c43b4
Diff: https://reviews.apache.org/r/58892/diff/2/
Changes: https://reviews.apache.org/r/58892/diff/1-2/
Testing
-------
Markdown viewer.
Thanks,
Jiang Yan Xu
Re: Review Request 58892: Added C++11 scoped enumeration to style
guide.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On May 2, 2017, 12:24 a.m., Michael Park wrote:
> > docs/c++-style-guide.md
> > Lines 649 (patched)
> > <https://reviews.apache.org/r/58892/diff/1/?file=1704582#file1704582line649>
> >
> > Maybe just mention `enum class` to eliminate confusion as to which one should be used?
+1.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58892/#review173566
-----------------------------------------------------------
On May 1, 2017, 2:07 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58892/
> -----------------------------------------------------------
>
> (Updated May 1, 2017, 2:07 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We've been using it for new code now.
>
>
> Diffs
> -----
>
> docs/c++-style-guide.md ccb81f48e2edc9c1e7c328cc26e44d658b4c43b4
>
>
> Diff: https://reviews.apache.org/r/58892/diff/1/
>
>
> Testing
> -------
>
> Markdown viewer.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 58892: Added C++11 scoped enumeration to style
guide.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58892/#review173566
-----------------------------------------------------------
docs/c++-style-guide.md
Lines 649 (patched)
<https://reviews.apache.org/r/58892/#comment246560>
Maybe just mention `enum class` to eliminate confusion as to which one should be used?
- Michael Park
On May 1, 2017, 2:07 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58892/
> -----------------------------------------------------------
>
> (Updated May 1, 2017, 2:07 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We've been using it for new code now.
>
>
> Diffs
> -----
>
> docs/c++-style-guide.md ccb81f48e2edc9c1e7c328cc26e44d658b4c43b4
>
>
> Diff: https://reviews.apache.org/r/58892/diff/1/
>
>
> Testing
> -------
>
> Markdown viewer.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>