You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "zhongyujiang (via GitHub)" <gi...@apache.org> on 2025/08/20 07:41:56 UTC
[PR] Core: Remove unsed file io parameter in TableMetadataParser.read. [iceberg]
zhongyujiang opened a new pull request, #13871:
URL: https://github.com/apache/iceberg/pull/13871
The file io parameter is never used in `TableMetadataParser#read(org.apache.iceberg.io.FileIO, org.apache.iceberg.io.InputFile)` and can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Remove unsed file io parameter in TableMetadataParser.read. [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #13871:
URL: https://github.com/apache/iceberg/pull/13871#discussion_r2287343975
##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -291,10 +291,18 @@ private static void toJson(Map<String, SnapshotRef> refs, JsonGenerator generato
}
public static TableMetadata read(FileIO io, String path) {
- return read(io, io.newInputFile(path));
+ return read(io.newInputFile(path));
}
+ /**
+ * @deprecated use {@link #read(InputFile)} instead.
Review Comment:
```suggestion
* @deprecated since 1.10.0, will be removed in 1.11.0; use {@link #read(InputFile)} instead.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Deprecate TableMetadataParser.read with unused file io parameter [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #13871:
URL: https://github.com/apache/iceberg/pull/13871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org