You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/12/21 08:48:21 UTC
[GitHub] [shardingsphere] totalo opened a new pull request #14193: Add distsql support about `show sql_parser rule`
totalo opened a new pull request #14193:
URL: https://github.com/apache/shardingsphere/pull/14193
For #13725.
Changes proposed in this pull request:
- add distsql support about `show sql_parser rule`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on a change in pull request #14193: Add distsql support about `show sql_parser rule`
Posted by GitBox <gi...@apache.org>.
totalo commented on a change in pull request #14193:
URL: https://github.com/apache/shardingsphere/pull/14193#discussion_r772956860
##########
File path: shardingsphere-distsql/shardingsphere-distsql-parser/src/main/java/org/apache/shardingsphere/distsql/parser/core/common/CommonDistSQLStatementVisitor.java
##########
@@ -191,6 +193,11 @@ public ASTNode visitShowSingleTable(final ShowSingleTableContext ctx) {
null == ctx.schemaName() ? null : (SchemaSegment) visit(ctx.schemaName()));
}
+ @Override
+ public ASTNode visitShowSQLParserRule(final ShowSQLParserRuleContext ctx) {
Review comment:
Just rewrite this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #14193: Add distsql support about `show sql_parser rule`
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #14193:
URL: https://github.com/apache/shardingsphere/pull/14193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #14193: Add distsql support about `show sql_parser rule`
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #14193:
URL: https://github.com/apache/shardingsphere/pull/14193#discussion_r772938311
##########
File path: shardingsphere-distsql/shardingsphere-distsql-parser/src/main/java/org/apache/shardingsphere/distsql/parser/core/common/CommonDistSQLStatementVisitor.java
##########
@@ -191,6 +193,11 @@ public ASTNode visitShowSingleTable(final ShowSingleTableContext ctx) {
null == ctx.schemaName() ? null : (SchemaSegment) visit(ctx.schemaName()));
}
+ @Override
+ public ASTNode visitShowSQLParserRule(final ShowSQLParserRuleContext ctx) {
Review comment:
what does this parameter use for ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org