You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@metron.apache.org by justinleet <gi...@git.apache.org> on 2018/05/15 17:49:52 UTC

[GitHub] metron pull request #1016: METRON-1564: Full dev kafka has offsets.topic.rep...

GitHub user justinleet opened a pull request:

    https://github.com/apache/metron/pull/1016

    METRON-1564: Full dev kafka has offsets.topic.replication.factor set to 3 instead of 1

    ## Contributor Comments
    Adds settings `offsets.topic.replication.factor` to 1 in single_node_vm.yml
    
    To test, spin up full dev. Go into Ambari -> Kafka -> Configs. Search for `offsets.topic.replication.factor`. Ensure it is set to one.  Ensure data still flows through to indexing (either by querying REST API or hitting Alerts UI).
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinleet/metron kafkaFullDevConfig

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1016.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1016
    
----
commit 4d148dc027abf60f445db9da97e4c5802b536cb4
Author: justinjleet <ju...@...>
Date:   2018-05-15T17:46:57Z

    Adding explicit property

----


---

[GitHub] metron pull request #1016: METRON-1564: Full dev kafka has offsets.topic.rep...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/metron/pull/1016


---

[GitHub] metron issue #1016: METRON-1564: Full dev kafka has offsets.topic.replicatio...

Posted by justinleet <gi...@git.apache.org>.

Github user justinleet commented on the issue:

    https://github.com/apache/metron/pull/1016
  
    I resolved this, but realized I should add onto Mike's comment for anyone else who looks back at this.
    
    The Ambari tooltip just documents the Kafka behavior, rather than being an indication of something Ambari handles.  The latest Ambari tooltip doesn't reference the min behavior anymore, because it no longer occurs.


---

[GitHub] metron issue #1016: METRON-1564: Full dev kafka has offsets.topic.replicatio...

Posted by mmiklavc <gi...@git.apache.org>.

Github user mmiklavc commented on the issue:

    https://github.com/apache/metron/pull/1016
  
    +1 by inspection. Note - per the comment for this setting that I see in Ambari, regardless of the value we set for offset replication, it will be `min(alive brokers, configured replication factor)`


---