You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/16 06:52:57 UTC
[GitHub] [apisix-ingress-controller] lingsamuel opened a new pull request, #1087: feat: support gateway TLSRoute
lingsamuel opened a new pull request, #1087:
URL: https://github.com/apache/apisix-ingress-controller/pull/1087
Signed-off-by: Ling Samuel <li...@gmail.com><!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [x] New feature provided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1087: feat: support gateway TLSRoute
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1087:
URL: https://github.com/apache/apisix-ingress-controller/pull/1087#issuecomment-1158508404
re-run all jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1087: feat: support gateway TLSRoute
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1087:
URL: https://github.com/apache/apisix-ingress-controller/pull/1087#issuecomment-1157310626
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1087?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1087](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1087?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a3dba9a) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/c48a62abfbd0b546c1d89bb7931caf1ed11abbb3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c48a62a) will **decrease** coverage by `0.66%`.
> The diff coverage is `0.53%`.
```diff
@@ Coverage Diff @@
## master #1087 +/- ##
==========================================
- Coverage 32.08% 31.42% -0.67%
==========================================
Files 78 80 +2
Lines 8795 8983 +188
==========================================
+ Hits 2822 2823 +1
- Misses 5666 5853 +187
Partials 307 307
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/gateway/translation/gateway.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZ2F0ZXdheS90cmFuc2xhdGlvbi9nYXRld2F5Lmdv) | `0.00% <0.00%> (ø)` | |
| [...kg/ingress/gateway/translation/gateway\_tlsroute.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZ2F0ZXdheS90cmFuc2xhdGlvbi9nYXRld2F5X3Rsc3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/ingress/gateway/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZ2F0ZXdheS90cmFuc2xhdGlvbi90cmFuc2xhdG9yLmdv) | `0.00% <ø> (ø)` | |
| [...g/ingress/gateway/translation/gateway\_httproute.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZ2F0ZXdheS90cmFuc2xhdGlvbi9nYXRld2F5X2h0dHByb3V0ZS5nbw==) | `64.10% <100.00%> (+0.23%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1087?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1087?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c48a62a...a3dba9a](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1087?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1087: feat: support gateway TLSRoute
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1087:
URL: https://github.com/apache/apisix-ingress-controller/pull/1087#issuecomment-1157345894
please fix lint error, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1087: feat: support gateway TLSRoute
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #1087:
URL: https://github.com/apache/apisix-ingress-controller/pull/1087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org