[GitHub] [incubator-kyuubi] link3280 commented on a change in pull request #1827: [KYUUBI #1825] Generate appName for Flink applications

[GitBox <gi...@apache.org>]

link3280 commented on a change in pull request #1827:
URL: https://github.com/apache/incubator-kyuubi/pull/1827#discussion_r790159191



##########
File path: externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/FlinkSQLEngine.scala
##########
@@ -72,6 +75,20 @@ object FlinkSQLEngine extends Logging {
     try {
       val flinkConfDir = CliFrontend.getConfigurationDirectoryFromEnv
       val flinkConf = GlobalConfiguration.loadConfiguration(flinkConfDir)
+
+      val executionTarget = flinkConf.getString(DeploymentOptions.TARGET)
+      // set cluster name for per-job and application mode
+      executionTarget match {
+        case "yarn-per-job" | "yarn-application" =>

Review comment:
       IIUC, in session mode we need to start a yarn session beforehand, so the cluster name/id is already determined, so here only includes application-mode cluster and per-job cluster, which is initialized lazily.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org