You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/30 01:42:52 UTC

[GitHub] [spark] cloud-fan commented on pull request #30865: [SPARK-33861][SQL] Simplify conditional in predicate

cloud-fan commented on PR #30865:
URL: https://github.com/apache/spark/pull/30865#issuecomment-1231044489

   conditional expressions is the only way people can control side effects. e.g. `IF(cond, trueExpr, falseExpr)` guarantees that `trueExpr` will only be evaluated if condition is true. This optimization breaks it and the benefits do not seem significant.
   
   @wangyum shall we revert this optimizer rule? cc @viirya @rednaxelafx @sigmod 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org