You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by so...@apache.org on 2017/03/07 02:16:30 UTC
[1/3] incubator-weex git commit: * [android] clear listener when
activity destroy to prevent memory leak
Repository: incubator-weex
Updated Branches:
refs/heads/0.11-dev 281dfad5b -> 1d9519c6a
* [android] clear listener when activity destroy to prevent memory leak
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/e74e7a8c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/e74e7a8c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/e74e7a8c
Branch: refs/heads/0.11-dev
Commit: e74e7a8c50f83ffff8271da5dc740312be3e4731
Parents: 5c1ded0
Author: lybeen <il...@gmail.com>
Authored: Fri Mar 3 15:15:55 2017 +0800
Committer: lybeen <il...@gmail.com>
Committed: Fri Mar 3 15:15:55 2017 +0800
----------------------------------------------------------------------
.../src/main/java/com/taobao/weex/ui/component/WXEmbed.java | 8 ++++++++
1 file changed, 8 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/e74e7a8c/android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java
----------------------------------------------------------------------
diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java
index 18aaafb..854828c 100755
--- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java
@@ -437,6 +437,14 @@ public class WXEmbed extends WXDiv implements WXSDKInstance.OnInstanceVisibleLis
}
}
+ @Override
+ public void onActivityDestroy() {
+ super.onActivityDestroy();
+ if (getInstance() != null) {
+ getInstance().removeOnInstanceVisibleListener(this);
+ }
+ }
+
private WXSDKInstance createInstance() {
WXSDKInstance sdkInstance = getInstance().createNestedInstance(this);
getInstance().addOnInstanceVisibleListener(this);
[2/3] incubator-weex git commit: * [android] remove clear listener to
destroy
Posted by so...@apache.org.
* [android] remove clear listener to destroy
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/4de221b9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/4de221b9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/4de221b9
Branch: refs/heads/0.11-dev
Commit: 4de221b9350f3b9521f821e9e31aa5a5c47e46b8
Parents: e74e7a8
Author: lybeen <il...@gmail.com>
Authored: Fri Mar 3 15:43:14 2017 +0800
Committer: lybeen <il...@gmail.com>
Committed: Fri Mar 3 15:43:14 2017 +0800
----------------------------------------------------------------------
.../main/java/com/taobao/weex/ui/component/WXEmbed.java | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/4de221b9/android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java
----------------------------------------------------------------------
diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java
index 854828c..033a05d 100755
--- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java
@@ -437,14 +437,6 @@ public class WXEmbed extends WXDiv implements WXSDKInstance.OnInstanceVisibleLis
}
}
- @Override
- public void onActivityDestroy() {
- super.onActivityDestroy();
- if (getInstance() != null) {
- getInstance().removeOnInstanceVisibleListener(this);
- }
- }
-
private WXSDKInstance createInstance() {
WXSDKInstance sdkInstance = getInstance().createNestedInstance(this);
getInstance().addOnInstanceVisibleListener(this);
@@ -501,6 +493,9 @@ public class WXEmbed extends WXDiv implements WXSDKInstance.OnInstanceVisibleLis
mNestedInstance = null;
}
src = null;
+ if (getInstance() != null) {
+ getInstance().removeOnInstanceVisibleListener(this);
+ }
}
@Override
[3/3] incubator-weex git commit: Merge branch '0.11-dev' of
https://git-wip-us.apache.org/repos/asf/incubator-weex;
branch 'android-bugfix-wxembed' of http://github.com/lybeen/incubator-weex
into 0.11-dev This closes #26
Posted by so...@apache.org.
Merge branch '0.11-dev' of https://git-wip-us.apache.org/repos/asf/incubator-weex; branch 'android-bugfix-wxembed' of http://github.com/lybeen/incubator-weex into 0.11-dev
This closes #26
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/1d9519c6
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/1d9519c6
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/1d9519c6
Branch: refs/heads/0.11-dev
Commit: 1d9519c6ab243bff0933b602b498b026eed9699a
Parents: 281dfad 4de221b
Author: sospartan <so...@gmail.com>
Authored: Tue Mar 7 10:16:07 2017 +0800
Committer: sospartan <so...@gmail.com>
Committed: Tue Mar 7 10:16:07 2017 +0800
----------------------------------------------------------------------
.../sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java | 3 +++
1 file changed, 3 insertions(+)
----------------------------------------------------------------------