You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/30 07:42:39 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5387: api: fix NPE with deployVirtualMachine when null boottype

sureshanaparti commented on a change in pull request #5387:
URL: https://github.com/apache/cloudstack/pull/5387#discussion_r698265614



##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##########
@@ -293,7 +292,8 @@ public Long getDomainId() {
             }
         }
         if (ApiConstants.BootType.UEFI.equals(getBootType())) {

Review comment:
       @shwstppr I think, no need to add (empty) boot type to custom parameters when boot mode is not specified.
   
   ```suggestion
           if (getBootMode() != null && ApiConstants.BootType.UEFI.equals(getBootType())) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org