You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@struts.apache.org by "bill-humblcloud (via GitHub)" <gi...@apache.org> on 2025/02/17 20:46:34 UTC
[PR] make DateConverter work for LocalDate and LocalTime [struts]
bill-humblcloud opened a new pull request, #1223:
URL: https://github.com/apache/struts/pull/1223
I found that the DateConverter class could not convert for java.time.LocalDate or java.time.LocalTime input—only java.time.LocalDateTime worked. The reason for this is that these types were not handled in the XWorkBasicConverter class; thus, they could not be properly directed to the DateConverter class. This simple patch fixes that deficiency. [This is my first pull request, so sorry if I've done anything wrong. I believe the online docs are somewhat out of date. ] Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5530 make DateConverter work for LocalDate and LocalTime [struts]
Posted by "bill-humblcloud (via GitHub)" <gi...@apache.org>.
bill-humblcloud commented on PR #1223:
URL: https://github.com/apache/struts/pull/1223#issuecomment-2682865030
I have modified XWorkConverterTest.testDateConversion() to include tests for LocalDate, LocalDateTime, and LocalTime. The tests seem to pass during the build process. I am new to GitHub, so I am working to figure out how to get those changes uploaded here (should've made notes the first time I did this). I will try to get that done in the next 24 hours (simultaneously working on a release of my own project, so I will do my best).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5530 make DateConverter work for LocalDate and LocalTime [struts]
Posted by "bill-humblcloud (via GitHub)" <gi...@apache.org>.
bill-humblcloud commented on PR #1223:
URL: https://github.com/apache/struts/pull/1223#issuecomment-2683355766
I believe the pull request now looks as it should with the test changes included. Please let me know if you see things differently. Thanks for the help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] make DateConverter work for LocalDate and LocalTime [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #1223:
URL: https://github.com/apache/struts/pull/1223#issuecomment-2664786193
Thanks for the PR. Could you create a ticket in JIRA which will relate to this change? Thanks in advance!
https://issues.apache.org/jira/projects/WW
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5530 make DateConverter work for LocalDate and LocalTime [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #1223:
URL: https://github.com/apache/struts/pull/1223#issuecomment-2684112850
Looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5530 make DateConverter work for LocalDate and LocalTime [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #1223:
URL: https://github.com/apache/struts/pull/1223#issuecomment-2682874667
You can edit the file in your fork [here](https://github.com/bill-humblcloud/struts/tree/humbl-fix) even directly via the web editor on Github, commit the changes and they should appear in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5530 make DateConverter work for LocalDate and LocalTime [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart merged PR #1223:
URL: https://github.com/apache/struts/pull/1223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5530 make DateConverter work for LocalDate and LocalTime [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #1223:
URL: https://github.com/apache/struts/pull/1223#issuecomment-2668270944
Great, could you extend `XWorkConverterTest` as well? There are already some test cases addressing conversion of dates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5530 make DateConverter work for LocalDate and LocalTime [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #1223:
URL: https://github.com/apache/struts/pull/1223#issuecomment-2682876828
Just copy paste your changes here https://github.com/bill-humblcloud/struts/blob/humbl-fix/core/src/test/java/org/apache/struts2/conversion/impl/XWorkConverterTest.java#L75-L103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5530 make DateConverter work for LocalDate and LocalTime [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #1223:
URL: https://github.com/apache/struts/pull/1223#issuecomment-2680699834
> Great, could you extend `XWorkConverterTest` as well? There are already some test cases addressing conversion of dates.
@bill-humblcloud do you have spare cycles to address this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org