[jira] [Assigned] (OOZIE-3429) PreCommit FindBugs checking does not work

["Julia Kinga Marton (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OOZIE-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julia Kinga Marton reassigned OOZIE-3429:
-----------------------------------------

    Assignee: Julia Kinga Marton

> PreCommit FindBugs checking does not work
> -----------------------------------------
>
>                 Key: OOZIE-3429
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3429
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Andras Salamon
>            Assignee: Julia Kinga Marton
>            Priority: Major
>
> PreCommit FindBugs checking stopped reporting errors one or two months ago. 
> The first patch of OOZIE-3427 was [reported|https://builds.apache.org/job/PreCommit-OOZIE-Build/992/consoleFull] to be good:
> {noformat}+1 There are no new bugs found in total.
>  +1 There are no new bugs found in [client].
>  +1 There are no new bugs found in [server].
>  +1 There are no new bugs found in [fluent-job/fluent-job-api].
>  +1 There are no new bugs found in [webapp].
>  +1 There are no new bugs found in [examples].
>  +1 There are no new bugs found in [core].
>  +1 There are no new bugs found in [docs].
>  +1 There are no new bugs found in [tools].
>  +1 There are no new bugs found in [sharelib/distcp].
>  +1 There are no new bugs found in [sharelib/oozie].
>  +1 There are no new bugs found in [sharelib/hive].
>  +1 There are no new bugs found in [sharelib/spark].
>  +1 There are no new bugs found in [sharelib/pig].
>  +1 There are no new bugs found in [sharelib/hcatalog].
>  +1 There are no new bugs found in [sharelib/sqoop].
>  +1 There are no new bugs found in [sharelib/hive2].
>  +1 There are no new bugs found in [sharelib/git].
>  +1 There are no new bugs found in [sharelib/streaming].
> {noformat}
> Executing the same test locally found one error:
> {noformat}+1 PATCH_APPLIES
> 0 There are [1] new bugs found in total that would be nice to have fixed.
>  +1 There are no new bugs found in [tools].
>  0 There are [1] new bugs found in [core] that would be nice to have fixed.
>  You can find the FindBugs diff here: core/findbugs-new.html
>  +1 There are no new bugs found in [webapp].
>  +1 There are no new bugs found in [fluent-job/fluent-job-api].
>  +1 There are no new bugs found in [server].
>  +1 There are no new bugs found in [docs].
>  +1 There are no new bugs found in [sharelib/pig].
>  +1 There are no new bugs found in [sharelib/sqoop].
>  +1 There are no new bugs found in [sharelib/hcatalog].
>  +1 There are no new bugs found in [sharelib/hive2].
>  +1 There are no new bugs found in [sharelib/streaming].
>  +1 There are no new bugs found in [sharelib/oozie].
>  +1 There are no new bugs found in [sharelib/hive].
>  +1 There are no new bugs found in [sharelib/distcp].
>  +1 There are no new bugs found in [sharelib/git].
>  +1 There are no new bugs found in [sharelib/spark].
>  +1 There are no new bugs found in [examples].
>  +1 There are no new bugs found in [client].
> ----------------------------
> +1 Overall result, good!, no -1s
> {noformat}
> Checking the output of the precommit shows that the patch is applied (at least the number of classes are increased):
> {noformat}$ diff FINDBUGS_DIFF-{clean,patch}.txt
> 541c541
> < [INFO] Compiling 575 source files to /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/classes
> ---
> > [INFO] Compiling 576 source files to /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/classes
> 568c568
> < [INFO] Compiling 392 source files to /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/test-classes
> ---
> > [INFO] Compiling 393 source files to /home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/core/target/test-classes
> ...
> {noformat}
> I've found one suspicious thing in the precommits logs:
> {noformat}[INFO] --- findbugs-maven-plugin:3.0.5:findbugs (findbugs) @ oozie-core ---
> [INFO] Fork Value is true
>      [java] The following classes needed for analysis were missing:
>      [java]   getSharelibNames
>      [java] Warnings generated: 781
>      [java] Missing classes: 1
> [INFO] Done FindBugs Analysis....
> {noformat}
> This {{getShareLibNames}} warning is not present in the local findbugs output.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)