Re: cvs commit: httpd-2.0/server/mpm/winnt mpm.h mpm_default.h mpm_winnt.c mpm_winnt.h

[Jim Jagielski <ji...@jaguNET.com>]

stoddard@apache.org wrote:
> 
>    
>   -    ap_sync_scoreboard_image();
>   +/*    ap_sync_scoreboard_image(); */
>        for (i = 0; i < HARD_SERVER_LIMIT; ++i) {

We don't need to sync?

>   
>   1.2       +71 -11    httpd-2.0/server/scoreboard.c
>   
>   Index: scoreboard.c
>    
>    #if APR_HAS_SHARED_MEMORY
>    #include "apr_shmem.h"
>   -
>    static apr_shmem_t *scoreboard_shm = NULL;
>   -
>   +#endif
>   +/*
>   + * ToDo:
>   + * This function should be renamed to cleanup_shared
>   + * and it should handle cleaning up a scoreboard shared
>   + * between processes using any form of IPC (file, shared memory
>   + * segment, etc.). Leave it as is now because it is being used
>   + * by various MPMs. 
>   + */
>    apr_status_t ap_cleanup_shared_mem(void *d)
>    {
>   +#if APR_HAD_SHARED_MEMORY

Should that be APR_HAS_SHARED_MEMORY ??
                   ---

>   +#if APR_HAD_SHARED_MEMORY

ditto here


-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
          "Casanova will have many weapons; To beat him you will
              have to have more than forks and flatulence."

Re: cvs commit: httpd-2.0/server/mpm/winnt mpm.h mpm_default.h mpm_winnt.c mpm_winnt.h

[Bill Stoddard <bi...@wstoddard.com>]

> stoddard@apache.org wrote:
> >
> >
> >   -    ap_sync_scoreboard_image();
> >   +/*    ap_sync_scoreboard_image(); */
> >        for (i = 0; i < HARD_SERVER_LIMIT; ++i) {
>
> We don't need to sync?
>

We need to sync if using a scoreboard file (which is not implemented now). I was getting a linking
error (that I still cannot explain)  so I commented it out. It needs to go back in when we implement
scoreboard files.

Bill