You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sarutak <gi...@git.apache.org> on 2015/01/20 20:54:17 UTC

[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

GitHub user sarutak opened a pull request:

    https://github.com/apache/spark/pull/4124

    [SPARK-5339][BUILD] build/mvn doesn't work because of invalid URL for maven's tgz.

    build/mvn will automatically download tarball of maven. But currently, the URL is invalid. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarutak/spark SPARK-5339

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/4124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4124
    
----
commit ca26499e597d407c6a37c57a409f469b70a50a66
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Date:   2015-01-20T19:53:28Z

    Fixed URL of the tarball of Maven

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-71538404
  
    Okay, LGTM good thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4124#discussion_r23253036
  
    --- Diff: build/mvn ---
    @@ -68,7 +68,7 @@ install_app() {
     # Install maven under the build/ folder
     install_mvn() {
       install_app \
    -    "http://apache.claz.org/maven/maven-3/3.2.3/binaries" \
    +    "http://archive.apache.org/dist/maven/maven-3/3.2.3/binaries" \
    --- End diff --
    
    @sarutak can you update to 3.2.5?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-71141530
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25989/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-70752178
  
      [Test build #25846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25846/consoleFull) for   PR 4124 at commit [`0e012d1`](https://github.com/apache/spark/commit/0e012d1d08c9c2caba890d2217b2991cb761a6a3).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-71141524
  
      [Test build #25989 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25989/consoleFull) for   PR 4124 at commit [`6e96121`](https://github.com/apache/spark/commit/6e96121473b9bd32ac38c5f069be75becf5134a0).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-70730822
  
      [Test build #25840 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25840/consoleFull) for   PR 4124 at commit [`0e012d1`](https://github.com/apache/spark/commit/0e012d1d08c9c2caba890d2217b2991cb761a6a3).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-71135691
  
      [Test build #25989 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25989/consoleFull) for   PR 4124 at commit [`6e96121`](https://github.com/apache/spark/commit/6e96121473b9bd32ac38c5f069be75becf5134a0).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-70752188
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25846/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-70733052
  
      [Test build #25835 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25835/consoleFull) for   PR 4124 at commit [`ca26499`](https://github.com/apache/spark/commit/ca26499e597d407c6a37c57a409f469b70a50a66).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/4124


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-70740219
  
    retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-70733065
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25835/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4124#discussion_r23250632
  
    --- Diff: build/mvn ---
    @@ -68,7 +68,7 @@ install_app() {
     # Install maven under the build/ folder
     install_mvn() {
       install_app \
    -    "http://apache.claz.org/maven/maven-3/3.2.3/binaries" \
    +    "http://archive.apache.org/dist/maven/maven-3/3.2.3/binaries" \
    --- End diff --
    
    While you're at it, point to 3.2.5? It's not ideal to point to `archive.apache.org` but at least it holds releases longer, whereas mirrors drop all but the latest point release in each line. I don't know of a redirector that would automatically send the request to a mirror though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4124#discussion_r23253060
  
    --- Diff: build/mvn ---
    @@ -68,7 +68,7 @@ install_app() {
     # Install maven under the build/ folder
     install_mvn() {
       install_app \
    -    "http://apache.claz.org/maven/maven-3/3.2.3/binaries" \
    +    "http://archive.apache.org/dist/maven/maven-3/3.2.3/binaries" \
    --- End diff --
    
    Of course.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-70721492
  
      [Test build #25835 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25835/consoleFull) for   PR 4124 at commit [`ca26499`](https://github.com/apache/spark/commit/ca26499e597d407c6a37c57a409f469b70a50a66).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-70730392
  
    @pwendell I've updated to `3.2.5` and confirmed build works with `build/mvn  package -DskipTests`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-70740706
  
      [Test build #25846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25846/consoleFull) for   PR 4124 at commit [`0e012d1`](https://github.com/apache/spark/commit/0e012d1d08c9c2caba890d2217b2991cb761a6a3).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4124#discussion_r23251861
  
    --- Diff: build/mvn ---
    @@ -68,7 +68,7 @@ install_app() {
     # Install maven under the build/ folder
     install_mvn() {
       install_app \
    -    "http://apache.claz.org/maven/maven-3/3.2.3/binaries" \
    +    "http://archive.apache.org/dist/maven/maven-3/3.2.3/binaries" \
    --- End diff --
    
    Yeah, if there are any redirectors, I'd like to use it but I also don't know so I chose `archive.apache.org`. For now, it's reliable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-70737328
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25840/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-5339][BUILD] build/mvn doesn't work bec...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4124#issuecomment-70737318
  
      [Test build #25840 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25840/consoleFull) for   PR 4124 at commit [`0e012d1`](https://github.com/apache/spark/commit/0e012d1d08c9c2caba890d2217b2991cb761a6a3).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org