You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2021/11/04 21:32:52 UTC
[native-toolchain-CR] IMPALA-11005 (part 1): Upgrade Boost library in toolchain
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17998
Change subject: IMPALA-11005 (part 1): Upgrade Boost library in toolchain
......................................................................
IMPALA-11005 (part 1): Upgrade Boost library in toolchain
Third party libraries - Boost, glog and protobuf in Impala native
tool-chains are be older than the corresponding libraries used by Kudu.
We need to upgrade these three libraries before rebase be/src/kudu.
This patch upgrades Boost from 1.61.0-p2 to 1.74.0-p1.
The two patches for Boost 1.61.0 are already merged to 1.74.0.
Need to add one patch which fixed the symbol visibility issue for
LLVM.
Testing:
- Built native toolchain on local machine.
- Built native toolchain with Jenkins job.
- Built Impala with upgraded toolchain and passed core test.
Change-Id: I3066286a6bdbf661c572bada4db69fb1b872bb16
---
M buildall.sh
A source/boost/boost-1.74.0-patches/0001-Fix-hidden-visibility-symbols-for-LLVM.patch
M source/boost/build.sh
3 files changed, 38 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/98/17998/2
--
To view, visit http://gerrit.cloudera.org:8080/17998
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3066286a6bdbf661c572bada4db69fb1b872bb16
Gerrit-Change-Number: 17998
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] IMPALA-11005 (part 1): Upgrade Boost library in toolchain
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17998 )
Change subject: IMPALA-11005 (part 1): Upgrade Boost library in toolchain
......................................................................
Patch Set 2: Code-Review+2
This looks good
--
To view, visit http://gerrit.cloudera.org:8080/17998
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3066286a6bdbf661c572bada4db69fb1b872bb16
Gerrit-Change-Number: 17998
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Nov 2021 17:36:00 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11005 (part 1): Upgrade Boost library in toolchain
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17998 )
Change subject: IMPALA-11005 (part 1): Upgrade Boost library in toolchain
......................................................................
IMPALA-11005 (part 1): Upgrade Boost library in toolchain
Third party libraries - Boost, glog and protobuf in Impala native
tool-chains are be older than the corresponding libraries used by Kudu.
We need to upgrade these three libraries before rebase be/src/kudu.
This patch upgrades Boost from 1.61.0-p2 to 1.74.0-p1.
The two patches for Boost 1.61.0 are already merged to 1.74.0.
Need to add one patch which fixed the symbol visibility issue for
LLVM.
Testing:
- Built native toolchain on local machine.
- Built native toolchain with Jenkins job.
- Built Impala with upgraded toolchain and passed core test.
Change-Id: I3066286a6bdbf661c572bada4db69fb1b872bb16
---
M buildall.sh
A source/boost/boost-1.74.0-patches/0001-Fix-hidden-visibility-symbols-for-LLVM.patch
M source/boost/build.sh
3 files changed, 38 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/98/17998/3
--
To view, visit http://gerrit.cloudera.org:8080/17998
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3066286a6bdbf661c572bada4db69fb1b872bb16
Gerrit-Change-Number: 17998
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] IMPALA-11005 (part 1): Upgrade Boost library in toolchain
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17998 )
Change subject: IMPALA-11005 (part 1): Upgrade Boost library in toolchain
......................................................................
IMPALA-11005 (part 1): Upgrade Boost library in toolchain
Third party libraries - Boost, glog and protobuf in Impala native
tool-chains are be older than the corresponding libraries used by Kudu.
We need to upgrade these three libraries before rebase be/src/kudu.
This patch upgrades Boost from 1.61.0-p2 to 1.74.0-p1.
The two patches for Boost 1.61.0 are already merged to 1.74.0.
Need to add one patch which fixed the symbol visibility issue for
LLVM.
Testing:
- Built native toolchain on local machine.
- Built native toolchain with Jenkins job.
- Built Impala with upgraded toolchain and passed core test.
Change-Id: I3066286a6bdbf661c572bada4db69fb1b872bb16
Reviewed-on: http://gerrit.cloudera.org:8080/17998
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Wenzhe Zhou <wz...@cloudera.com>
---
M buildall.sh
A source/boost/boost-1.74.0-patches/0001-Fix-hidden-visibility-symbols-for-LLVM.patch
M source/boost/build.sh
3 files changed, 38 insertions(+), 3 deletions(-)
Approvals:
Wenzhe Zhou: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17998
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3066286a6bdbf661c572bada4db69fb1b872bb16
Gerrit-Change-Number: 17998
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>