You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "reswqa (via GitHub)" <gi...@apache.org> on 2023/03/07 17:41:39 UTC

[GitHub] [flink] reswqa opened a new pull request, #22125: [FLINK-31360][test] Using an executor service which ignore rejectException as shutdown for HsResultPartitionTest.

reswqa opened a new pull request, #22125:
URL: https://github.com/apache/flink/pull/22125

   ## What is the purpose of the change
   
   *After FLINK-31346, IO Scheduler will shutdown JVM If unexpected errors are encountered in `run` method. But for `HsResultPartitionTest`, IO executor will be shut down after each test class and working IO thread has the probability to continue to submit the scheduled task to it, thus throw  rejectException.*
   
   
   ## Brief change log
   
     - *Using an executor service which ignore rejectException as shutdown for HsResultPartitionTest.*
   
   
   ## Verifying this change
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] TanYuxin-tyx commented on pull request #22125: [FLINK-31360][test] Using an executor service which ignore rejectException as shutdown for HsResultPartitionTest.

Posted by "TanYuxin-tyx (via GitHub)" <gi...@apache.org>.
TanYuxin-tyx commented on PR #22125:
URL: https://github.com/apache/flink/pull/22125#issuecomment-1459208813

   This change LGTM. 
   I found similar solutions to the issue, e.g., in SchedulerFactory, KubernetesLeaderElector, etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #22125: [FLINK-31360][test] Using an executor service which ignore rejectException as shutdown for HsResultPartitionTest.

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22125:
URL: https://github.com/apache/flink/pull/22125#issuecomment-1458586494

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "eeb064ad4ed905531db0320b28a85d1d69dc7dcd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "eeb064ad4ed905531db0320b28a85d1d69dc7dcd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * eeb064ad4ed905531db0320b28a85d1d69dc7dcd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] reswqa merged pull request #22125: [FLINK-31360][test] Using an executor service which ignore rejectException as shutdown for HsResultPartitionTest.

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa merged PR #22125:
URL: https://github.com/apache/flink/pull/22125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org