You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/08 14:55:16 UTC

[GitHub] [superset] john-bodley commented on a diff in pull request #21729: fix: allow adhoc columns in non-aggregate query

john-bodley commented on code in PR #21729:
URL: https://github.com/apache/superset/pull/21729#discussion_r1016738040


##########
superset/connectors/sqla/models.py:
##########
@@ -119,6 +119,7 @@
 from superset.superset_typing import (
     AdhocColumn,
     AdhocMetric,
+    Column as ColumnTyping,

Review Comment:
   @mayurnewase out of interest why did you rename this? There doesn't seem to be a name clash per your change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org