You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/07 10:08:08 UTC
[GitHub] [pulsar] yuruguo opened a new pull request #12656: [Authorization] Fix not support GET_METADATA topic operation
yuruguo opened a new pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656
### Motivation
Currently, we can get the internal stats of a topic through `bin/pulsar-admin topics stats-internal tn1/ns1/tp1` and also get ledger metadata by specifying flag `--metadata`.
However I found that `PulsarAuthorizationProvider` lacks support for topic operation `GET_METADATA` when verifying the role's authorization, code as below:
https://github.com/apache/pulsar/blob/08a49c06bff4a52d26319a114961aed6cb6c4791/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java#L1162-L1164
https://github.com/apache/pulsar/blob/08a49c06bff4a52d26319a114961aed6cb6c4791/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java#L567-L596
The purpose of this PR is to support role with `lookup` authorization to `GET_METADATA`.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962591280
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962586654
@lhotari @codelipenghui @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962701662
@merlimat @hangc0276 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12656: [Authorization] Support GET_METADATA topic op after enable auth
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962584862
@lhotari @eolivelli @codelipenghui @freeznet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962591280
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962695425
> @yuruguo Could you please help add a test? The change looks good to me.
Okay :)
Done, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962586654
@lhotari @codelipenghui @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962584862
@lhotari @eolivelli @codelipenghui @freeznet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12656: [Authorization] Fix not support GET_METADATA topic operation
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962701662
@merlimat @hangc0276 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org