[jira] Commented: (DIRSTUDIO-100) Interface IRootDSE does not sufficiently define return values of methods

["Stefan Seelmann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DIRSTUDIO-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494852 ] 

Stefan Seelmann commented on DIRSTUDIO-100:
-------------------------------------------

Stefan, you are totally right. The interface lacks on documentation and the RootDSE class implementation is bad. Thanks for heads up. As you suggest the best way would be to return the OIDs only. BTW, the methods are only used from the RootDSEPropertyPage.

> Interface IRootDSE does not sufficiently define return values of methods
> ------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-100
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-100
>             Project: Directory LDAP Studio
>          Issue Type: Wish
>            Reporter: Stefan Zoerner
>             Fix For: 0.8.0
>
>
> I think the interface org.apache.directory.ldapstudio.browser.core.model.IRootDSE does not sufficiently define the return values for the following methods
> * getSupportedExtensions
> * getSupportedControls
> * getSupportedFeatures
> Do they return the OIDs, or a name, or a description (what language)? 
> The implementation 
> org.apache.directory.ldapstudio.browser.core.internal.model.RootDSE
> for instance replaces OIDs with names from a map file, if they are contained in it. It is therefore not easy to determine whether a given LDAP control etc. is supported or not. I recommend to define that the return values of type String[] always return the OIDs, and a translation into text (if necessary) is due to UI classes only.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.