You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/12 06:56:50 UTC
[GitHub] [rocketmq-apis] lollipopjin opened a new pull request, #33: [ISSUE #32] add check_message_type to publishing setting.
lollipopjin opened a new pull request, #33:
URL: https://github.com/apache/rocketmq-apis/pull/33
add check_message_type to publishing setting, no need to check message's type when this flag set false from server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] lizhanhui commented on a diff in pull request #33: [ISSUE #32] add check_message_type to publishing setting.
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #33:
URL: https://github.com/apache/rocketmq-apis/pull/33#discussion_r875700546
##########
apache/rocketmq/v2/service.proto:
##########
@@ -193,6 +193,10 @@ message Publishing {
// reject the request. As a result, it is advisable that Producer performs
// client-side check validation.
int32 max_body_size = 3;
+
+ // When `check_message_type` flag set `false`, no need to check message's type
+ // with messageQueue's `accept_message_types` before publising.
+ bool check_message_type = 4;
Review Comment:
It's generally discouraged to use bool in the protocol definition. Prefer explicit enum.
For example
enum ValidateMessageTypeStrategy {
UNSPECIFIED = 0,
DISABLED = 1,
PERMISSIVE = 2,
ENFORCING = 3,
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] lollipopjin commented on a diff in pull request #33: [ISSUE #32] add check_message_type to publishing setting.
Posted by GitBox <gi...@apache.org>.
lollipopjin commented on code in PR #33:
URL: https://github.com/apache/rocketmq-apis/pull/33#discussion_r874455424
##########
apache/rocketmq/v2/service.proto:
##########
@@ -193,6 +193,10 @@ message Publishing {
// reject the request. As a result, it is advisable that Producer performs
// client-side check validation.
int32 max_body_size = 3;
+
+ // When `check_message_type` flag set `false`, no need to check message's type
+ // with messageQueue's `accept_message_types` before publising.
+ optional bool check_message_type = 4;
Review Comment:
fixed. anyway, the server will push it's default setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] aaron-ai commented on a diff in pull request #33: [ISSUE #32] add check_message_type to publishing setting.
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on code in PR #33:
URL: https://github.com/apache/rocketmq-apis/pull/33#discussion_r871940188
##########
apache/rocketmq/v2/service.proto:
##########
@@ -193,6 +193,10 @@ message Publishing {
// reject the request. As a result, it is advisable that Producer performs
// client-side check validation.
int32 max_body_size = 3;
+
+ // When `check_message_type` flag set `false`, no need to check message's type
+ // with messageQueue's `accept_message_types` before publising.
+ optional bool check_message_type = 4;
Review Comment:
When do we not fill the field since it is optional?
##########
apache/rocketmq/v2/service.proto:
##########
@@ -193,6 +193,10 @@ message Publishing {
// reject the request. As a result, it is advisable that Producer performs
// client-side check validation.
int32 max_body_size = 3;
+
+ // When `check_message_type` flag set `false`, no need to check message's type
+ // with messageQueue's `accept_message_types` before publising.
+ optional bool check_message_type = 4;
Review Comment:
When do we not fill the field since it is optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] aaron-ai commented on pull request #33: [ISSUE #32] add check_message_type to publishing setting.
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on PR #33:
URL: https://github.com/apache/rocketmq-apis/pull/33#issuecomment-1129792507
@lizhanhui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] lizhanhui merged pull request #33: [ISSUE #32] add check_message_type to publishing setting.
Posted by GitBox <gi...@apache.org>.
lizhanhui merged PR #33:
URL: https://github.com/apache/rocketmq-apis/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org