[GitHub] [superset] mebegu commented on pull request #21180: feat: add snowflake private key support

[GitBox <gi...@apache.org>]

mebegu commented on PR #21180:
URL: https://github.com/apache/superset/pull/21180#issuecomment-1231396961

   Thanks for implementing this feature @xiayanzheng. We need key-pair authentication in our project too. I was searching for how can I include it in superset, and I encountered your pull request. Hope it would be merged soon :grimacing: 
   
   @dpgaspar @villebro 
   I've seen you reviewed another pull request for this project recently. How does the review process go? Can we prioritize this small feature? :upside_down_face:  Because, there is no way-around to use keypair auth for snowflake in superset, and we are kinda blocked in our project at the moment.
   
   About the implementation, in [the official snowflake docs](https://docs.snowflake.com/en/user-guide/python-connector-example.html#using-key-pair-authentication-key-pair-rotation), the decryption of the private key has been explained exactly the same method with this pull request. 
   
   Similarly, in [the snowflake-sqlalchemy repository docs](https://github.com/snowflakedb/snowflake-sqlalchemy#key-pair-authentication-support), the private key has been passed into `connect_args` as bytes during the engine creation, which is same as in the pull request.
   
   So, technical wise, it looks good to me. :slightly_smiling_face: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org