You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "hangc0276 (via GitHub)" <gi...@apache.org> on 2023/10/23 03:51:35 UTC
Re: [PR] Fix verifyDirsForNewEnvironment [bookkeeper]
hangc0276 commented on code in PR #4085:
URL: https://github.com/apache/bookkeeper/pull/4085#discussion_r1368095636
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LegacyCookieValidation.java:
##########
@@ -94,7 +94,7 @@ public void checkCookies(List<File> directories) throws BookieException {
if (!missedCookieDirs.isEmpty()) {
if (rmCookie == null) {
// 5.1 new environment: all directories should be empty
- verifyDirsForNewEnvironment(missedCookieDirs);
+ verifyDirsForNewEnvironment(directories);
Review Comment:
Have you encountered any exceptions? The missedCookieDirs is the result of checking remote cookies and directories
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org