[GitHub] [trafficserver] sudheerv commented on a change in pull request #6772: Ensure inactivity timeout is not set when passed in timeout value is 0

[GitBox <gi...@apache.org>]

sudheerv commented on a change in pull request #6772:
URL: https://github.com/apache/trafficserver/pull/6772#discussion_r424711257



##########
File path: iocore/net/UnixNetVConnection.cc
##########
@@ -1353,7 +1353,7 @@ UnixNetVConnection::set_inactivity_timeout(ink_hrtime timeout_in)
 {
   Debug("socket", "Set inactive timeout=%" PRId64 ", for NetVC=%p", timeout_in, this);
   inactivity_timeout_in      = timeout_in;
-  next_inactivity_timeout_at = Thread::get_hrtime() + inactivity_timeout_in;
+  next_inactivity_timeout_at = (timeout_in > 0) ? Thread::get_hrtime() + inactivity_timeout_in : 0;

Review comment:
       Yeah,  talked to Bryan on slack. We will use this defensiveness to rely on default inactivity to prevent accidental misconfigurations for inactivity timeout, but do a debug assert for 0 timeout.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org